Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/browser/resources/downloads/item_view.js

Issue 1228263002: Fix downloads-related web_dev_style presubmit issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dl-rough-draft2
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('downloads', function() { 5 cr.define('downloads', function() {
6 /** 6 /**
7 * Creates and updates the DOM representation for a download. 7 * Creates and updates the DOM representation for a download.
8 * @param {!downloads.ThrottledIconLoader} iconLoader 8 * @param {!downloads.ThrottledIconLoader} iconLoader
9 * @constructor 9 * @constructor
10 */ 10 */
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 183
184 this.pause_.hidden = !isInProgress; 184 this.pause_.hidden = !isInProgress;
185 185
186 this.resume_.hidden = !data.resume; 186 this.resume_.hidden = !data.resume;
187 187
188 /** @const */ var isPaused = data.state == downloads.States.PAUSED; 188 /** @const */ var isPaused = data.state == downloads.States.PAUSED;
189 /** @const */ var showCancel = isPaused || isInProgress; 189 /** @const */ var showCancel = isPaused || isInProgress;
190 this.cancel_.hidden = !showCancel; 190 this.cancel_.hidden = !showCancel;
191 191
192 this.safeRemove_.hidden = showCancel || 192 this.safeRemove_.hidden = showCancel ||
193 !loadTimeData.getBoolean('allow_deleting_history'); 193 !loadTimeData.getBoolean('allowDeletingHistory');
194 194
195 /** @const */ var controlledByExtension = data.by_ext_id && 195 /** @const */ var controlledByExtension = data.by_ext_id &&
196 data.by_ext_name; 196 data.by_ext_name;
197 this.controlledBy_.hidden = !controlledByExtension; 197 this.controlledBy_.hidden = !controlledByExtension;
198 if (controlledByExtension) { 198 if (controlledByExtension) {
199 var link = this.controlledBy_.querySelector('a'); 199 var link = this.controlledBy_.querySelector('a');
200 link.href = 'chrome://extensions#' + data.by_ext_id; 200 link.href = 'chrome://extensions#' + data.by_ext_id;
201 link.setAttribute('column-type', 'controlled-by'); 201 link.setAttribute('column-type', 'controlled-by');
202 link.textContent = data.by_ext_name; 202 link.textContent = data.by_ext_name;
203 } 203 }
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 }, 279 },
280 280
281 /** 281 /**
282 * @param {!downloads.Data} data 282 * @param {!downloads.Data} data
283 * @return {string} Text describing the danger of a download. Empty if not 283 * @return {string} Text describing the danger of a download. Empty if not
284 * dangerous. 284 * dangerous.
285 */ 285 */
286 getDangerText_: function(data) { 286 getDangerText_: function(data) {
287 switch (data.danger_type) { 287 switch (data.danger_type) {
288 case downloads.DangerType.DANGEROUS_FILE: 288 case downloads.DangerType.DANGEROUS_FILE:
289 return loadTimeData.getStringF('danger_file_desc', data.file_name); 289 return loadTimeData.getStringF('dangerFileDesc', data.file_name);
290 case downloads.DangerType.DANGEROUS_URL: 290 case downloads.DangerType.DANGEROUS_URL:
291 return loadTimeData.getString('danger_url_desc'); 291 return loadTimeData.getString('dangerUrlDesc');
292 case downloads.DangerType.DANGEROUS_CONTENT: // Fall through. 292 case downloads.DangerType.DANGEROUS_CONTENT: // Fall through.
293 case downloads.DangerType.DANGEROUS_HOST: 293 case downloads.DangerType.DANGEROUS_HOST:
294 return loadTimeData.getStringF('danger_content_desc', data.file_name); 294 return loadTimeData.getStringF('dangerContentDesc', data.file_name);
295 case downloads.DangerType.UNCOMMON_CONTENT: 295 case downloads.DangerType.UNCOMMON_CONTENT:
296 return loadTimeData.getStringF('danger_uncommon_desc', 296 return loadTimeData.getStringF('dangerUncommonDesc', data.file_name);
297 data.file_name);
298 case downloads.DangerType.POTENTIALLY_UNWANTED: 297 case downloads.DangerType.POTENTIALLY_UNWANTED:
299 return loadTimeData.getStringF('danger_settings_desc', 298 return loadTimeData.getStringF('dangerSettingsDesc', data.file_name);
300 data.file_name);
301 default: 299 default:
302 return ''; 300 return '';
303 } 301 }
304 }, 302 },
305 303
306 /** 304 /**
307 * @param {!downloads.Data} data 305 * @param {!downloads.Data} data
308 * @return {string} User-visible status update text. 306 * @return {string} User-visible status update text.
309 * @private 307 * @private
310 */ 308 */
311 getStatusText_: function(data) { 309 getStatusText_: function(data) {
312 switch (data.state) { 310 switch (data.state) {
313 case downloads.States.IN_PROGRESS: 311 case downloads.States.IN_PROGRESS:
314 case downloads.States.PAUSED: // Fallthrough. 312 case downloads.States.PAUSED: // Fallthrough.
315 assert(typeof data.progress_status_text == 'string'); 313 assert(typeof data.progress_status_text == 'string');
316 return data.progress_status_text; 314 return data.progress_status_text;
317 case downloads.States.CANCELLED: 315 case downloads.States.CANCELLED:
318 return loadTimeData.getString('status_cancelled'); 316 return loadTimeData.getString('statusCancelled');
319 case downloads.States.DANGEROUS: 317 case downloads.States.DANGEROUS:
320 break; // Intentionally hit assertNotReached(); at bottom. 318 break; // Intentionally hit assertNotReached(); at bottom.
321 case downloads.States.INTERRUPTED: 319 case downloads.States.INTERRUPTED:
322 assert(typeof data.last_reason_text == 'string'); 320 assert(typeof data.last_reason_text == 'string');
323 return data.last_reason_text; 321 return data.last_reason_text;
324 case downloads.States.COMPLETE: 322 case downloads.States.COMPLETE:
325 return data.file_externally_removed ? 323 return data.file_externally_removed ?
326 loadTimeData.getString('status_removed') : ''; 324 loadTimeData.getString('statusRemoved') : '';
327 } 325 }
328 assertNotReached(); 326 assertNotReached();
329 return ''; 327 return '';
330 }, 328 },
331 329
332 /** 330 /**
333 * @private 331 * @private
334 * @param {Event} e 332 * @param {Event} e
335 */ 333 */
336 onSafeDragstart_: function(e) { 334 onSafeDragstart_: function(e) {
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 }, 386 },
389 387
390 /** @private */ 388 /** @private */
391 onDiscardClick_: function() { 389 onDiscardClick_: function() {
392 chrome.send('discardDangerous', [this.id_]); 390 chrome.send('discardDangerous', [this.id_]);
393 }, 391 },
394 }; 392 };
395 393
396 return {ItemView: ItemView}; 394 return {ItemView: ItemView};
397 }); 395 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/downloads/downloads.html ('k') | chrome/browser/resources/downloads/manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698