Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1228253002: Remove |cgl_context| from VTVideoDecodeAccelerator. (Closed)

Created:
5 years, 5 months ago by sandersd (OOO until July 31)
Modified:
5 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |cgl_context| from VTVideoDecodeAccelerator. Instead of explicitly passing |cgl_context|, get it from GLContext::GetCurrent(). Committed: https://crrev.com/ea47d8141292d0b6f87fe292a795c655460afaab Cr-Commit-Position: refs/heads/master@{#338219}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 5 chunks +8 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
sandersd (OOO until July 31)
Not very different, but |cgl_context| was only used for CGLTexImageIOSurface2D(). GLImageIOSurface, the proposed replacement for ...
5 years, 5 months ago (2015-07-10 00:50:42 UTC) #2
DaleCurtis
lgtm % question https://codereview.chromium.org/1228253002/diff/1/content/common/gpu/media/vt_video_decode_accelerator.cc File content/common/gpu/media/vt_video_decode_accelerator.cc (right): https://codereview.chromium.org/1228253002/diff/1/content/common/gpu/media/vt_video_decode_accelerator.cc#newcode1011 content/common/gpu/media/vt_video_decode_accelerator.cc:1011: glDisable(GL_TEXTURE_RECTANGLE_ARB); Why the move to before ...
5 years, 5 months ago (2015-07-10 00:53:46 UTC) #3
sandersd (OOO until July 31)
On 2015/07/10 00:53:46, DaleCurtis wrote: > lgtm % question > > https://codereview.chromium.org/1228253002/diff/1/content/common/gpu/media/vt_video_decode_accelerator.cc > File content/common/gpu/media/vt_video_decode_accelerator.cc ...
5 years, 5 months ago (2015-07-10 00:59:16 UTC) #4
DaleCurtis
Ah didn't see the glEnable above. lgtm!
5 years, 5 months ago (2015-07-10 01:00:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228253002/1
5 years, 5 months ago (2015-07-10 01:03:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 02:41:41 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 02:43:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea47d8141292d0b6f87fe292a795c655460afaab
Cr-Commit-Position: refs/heads/master@{#338219}

Powered by Google App Engine
This is Rietveld 408576698