Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 1228233007: Shows error messages in the inspector when .respondWith() is called with wrong responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/RespondWithObserver.h
diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h
index ebb46c42f87477e59ec31e16e99fe221726d9309..0bbd77ea7b17b3514299baff2f081987ccef4ac2 100644
--- a/Source/modules/serviceworkers/RespondWithObserver.h
+++ b/Source/modules/serviceworkers/RespondWithObserver.h
@@ -23,7 +23,7 @@ class ScriptValue;
class MODULES_EXPORT RespondWithObserver final : public GarbageCollectedFinalized<RespondWithObserver>, public ContextLifecycleObserver {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RespondWithObserver);
public:
- static RespondWithObserver* create(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
+ static RespondWithObserver* create(ExecutionContext*, int eventID, const KURL&, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
falken 2015/07/10 11:20:44 I think this needs a param name, it's not obvious
horo 2015/07/10 12:13:27 Done.
virtual void contextDestroyed() override;
@@ -41,9 +41,10 @@ public:
private:
class ThenFunction;
- RespondWithObserver(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
+ RespondWithObserver(ExecutionContext*, int eventID, const KURL&, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
int m_eventID;
+ KURL m_requestURL;
WebURLRequest::FetchRequestMode m_requestMode;
WebURLRequest::FrameType m_frameType;

Powered by Google App Engine
This is Rietveld 408576698