Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 1228233007: Shows error messages in the inspector when .respondWith() is called with wrong responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated falken's comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/RespondWithObserver.h
diff --git a/Source/modules/serviceworkers/RespondWithObserver.h b/Source/modules/serviceworkers/RespondWithObserver.h
index 24639384e9653513cdff4033044b4c6d1d9012ad..74c0766ec91dbcb528ccb78f4ea1e90f8ce0241e 100644
--- a/Source/modules/serviceworkers/RespondWithObserver.h
+++ b/Source/modules/serviceworkers/RespondWithObserver.h
@@ -23,7 +23,7 @@ class ScriptValue;
class MODULES_EXPORT RespondWithObserver final : public GarbageCollectedFinalized<RespondWithObserver>, public ContextLifecycleObserver {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RespondWithObserver);
public:
- static RespondWithObserver* create(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
+ static RespondWithObserver* create(ExecutionContext*, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
void contextDestroyed() override;
@@ -41,9 +41,10 @@ public:
private:
class ThenFunction;
- RespondWithObserver(ExecutionContext*, int eventID, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
+ RespondWithObserver(ExecutionContext*, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
int m_eventID;
+ KURL m_requestURL;
WebURLRequest::FetchRequestMode m_requestMode;
WebURLRequest::FrameType m_frameType;
« no previous file with comments | « no previous file | Source/modules/serviceworkers/RespondWithObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698