Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: Source/modules/serviceworkers/RespondWithObserver.h

Issue 1228233007: Shows error messages in the inspector when .respondWith() is called with wrong responses. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated falken's comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef RespondWithObserver_h 5 #ifndef RespondWithObserver_h
6 #define RespondWithObserver_h 6 #define RespondWithObserver_h
7 7
8 #include "core/dom/ContextLifecycleObserver.h" 8 #include "core/dom/ContextLifecycleObserver.h"
9 #include "modules/ModulesExport.h" 9 #include "modules/ModulesExport.h"
10 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
11 #include "public/platform/WebServiceWorkerResponseError.h" 11 #include "public/platform/WebServiceWorkerResponseError.h"
12 #include "public/platform/WebURLRequest.h" 12 #include "public/platform/WebURLRequest.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 class ExceptionState; 16 class ExceptionState;
17 class ExecutionContext; 17 class ExecutionContext;
18 class ScriptState; 18 class ScriptState;
19 class ScriptValue; 19 class ScriptValue;
20 20
21 // This class observes the service worker's handling of a FetchEvent and 21 // This class observes the service worker's handling of a FetchEvent and
22 // notifies the client. 22 // notifies the client.
23 class MODULES_EXPORT RespondWithObserver final : public GarbageCollectedFinalize d<RespondWithObserver>, public ContextLifecycleObserver { 23 class MODULES_EXPORT RespondWithObserver final : public GarbageCollectedFinalize d<RespondWithObserver>, public ContextLifecycleObserver {
24 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RespondWithObserver); 24 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RespondWithObserver);
25 public: 25 public:
26 static RespondWithObserver* create(ExecutionContext*, int eventID, WebURLReq uest::FetchRequestMode, WebURLRequest::FrameType); 26 static RespondWithObserver* create(ExecutionContext*, int eventID, const KUR L& requestURL, WebURLRequest::FetchRequestMode, WebURLRequest::FrameType);
27 27
28 virtual void contextDestroyed() override; 28 virtual void contextDestroyed() override;
29 29
30 void didDispatchEvent(bool defaultPrevented); 30 void didDispatchEvent(bool defaultPrevented);
31 31
32 // Observes the promise and delays calling didHandleFetchEvent() until the 32 // Observes the promise and delays calling didHandleFetchEvent() until the
33 // given promise is resolved or rejected. 33 // given promise is resolved or rejected.
34 void respondWith(ScriptState*, const ScriptValue&, ExceptionState&); 34 void respondWith(ScriptState*, const ScriptValue&, ExceptionState&);
35 35
36 void responseWasRejected(WebServiceWorkerResponseError); 36 void responseWasRejected(WebServiceWorkerResponseError);
37 void responseWasFulfilled(const ScriptValue&); 37 void responseWasFulfilled(const ScriptValue&);
38 38
39 DECLARE_VIRTUAL_TRACE(); 39 DECLARE_VIRTUAL_TRACE();
40 40
41 private: 41 private:
42 class ThenFunction; 42 class ThenFunction;
43 43
44 RespondWithObserver(ExecutionContext*, int eventID, WebURLRequest::FetchRequ estMode, WebURLRequest::FrameType); 44 RespondWithObserver(ExecutionContext*, int eventID, const KURL&, WebURLReque st::FetchRequestMode, WebURLRequest::FrameType);
falken 2015/07/14 12:58:55 probably should write requestURL here too
horo 2015/07/15 02:32:10 Done.
45 45
46 int m_eventID; 46 int m_eventID;
47 KURL m_requestURL;
47 WebURLRequest::FetchRequestMode m_requestMode; 48 WebURLRequest::FetchRequestMode m_requestMode;
48 WebURLRequest::FrameType m_frameType; 49 WebURLRequest::FrameType m_frameType;
49 50
50 enum State { Initial, Pending, Done }; 51 enum State { Initial, Pending, Done };
51 State m_state; 52 State m_state;
52 }; 53 };
53 54
54 } // namespace blink 55 } // namespace blink
55 56
56 #endif // RespondWithObserver_h 57 #endif // RespondWithObserver_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698