Shows error messages in the inspector when .respondWith() is called with wrong responses.

Source/modules/serviceworkers/RespondWithObserver.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/serviceworkers/RespondWithObserver.h"
 
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/modules/v8/V8Response.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/inspector/ConsoleMessage.h"
 #include "core/streams/Stream.h"
 #include "modules/fetch/BodyStreamBuffer.h"
 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "public/platform/WebServiceWorkerResponse.h"
 #include "wtf/Assertions.h"
 #include "wtf/RefPtr.h"
 #include <v8.h>
 
 namespace blink {
+namespace {
+
+// Outputs the error message to let the developer know about the reason of the unusual failures.
+void maybeOutputErrorMessage(ExecutionContext* context, WebServiceWorkerResponseError error, const KURL& requestURL)

[falken, 2015/07/14 12:58:55]

Shouldn't be "maybe" anymore since it always outputs? Might be cleaner now for
this to just be "getMessageForResponseError()", and have responseWasRejected
actually call addConsoleMessage().

[horo, 2015/07/15 02:32:09]

Done.

+{
+    String errorMessage = "The FetchEvent for \"" + requestURL.string() + "\" resulted in a network error response: ";
+    switch (error) {
+    case WebServiceWorkerResponseErrorPromiseRejected:
+        errorMessage = errorMessage + "the promise was rejected.";
+        break;
+    case WebServiceWorkerResponseErrorDefaultPrevented:
+        errorMessage = errorMessage + "preventDefault() was called without calling respondWith().";
+        break;
+    case WebServiceWorkerResponseErrorNoV8Instance:
+        errorMessage = errorMessage + "an object that was not a Response was passed to respondWith().";
+        break;
+    case WebServiceWorkerResponseErrorResponseTypeError:
+        errorMessage = errorMessage + "the promise was resolved with an error response object.";
+        break;
+    case WebServiceWorkerResponseErrorResponseTypeOpaque:
+        errorMessage = errorMessage + "an \"opaque\" response was used for a request whose type is not no-cors";
+        break;
+    case WebServiceWorkerResponseErrorResponseTypeNotBasicOrDefault:
+        errorMessage = errorMessage + "the response for a client request must have type \"basic\" or \"default\".";
+        break;
+    case WebServiceWorkerResponseErrorBodyUsed:
+        errorMessage = errorMessage + "a Response whose \"bodyUsed\" is \"true\" cannot be used to respond to a request.";
+        break;
+    case WebServiceWorkerResponseErrorUnknown:
+    default:
+        errorMessage = errorMessage + "an unexpected error occurred.";
+        break;
+    }
+    context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, InfoMessageLevel, errorMessage));

[falken, 2015/07/14 12:58:55]

on second thought Warning is probably more appropriate so they see warning icon
in DevTools (kind of just guessing though).

[horo, 2015/07/15 02:32:09]

Done.

+}
+
+} // namespace
 
 class RespondWithObserver::ThenFunction final : public ScriptFunction {
 public:
     enum ResolveType {
         Fulfilled,
         Rejected,
     };
 
     static v8::Local<v8::Function> createFunction(ScriptState* scriptState, RespondWithObserver* observer, ResolveType type)
     {
@@ skipping 26 matching lines @@
             m_observer->responseWasFulfilled(value);
         }
         m_observer = nullptr;
         return value;
     }
 
     Member<RespondWithObserver> m_observer;
     ResolveType m_resolveType;
 };
 
-RespondWithObserver* RespondWithObserver::create(ExecutionContext* context, int eventID, WebURLRequest::FetchRequestMode requestMode, WebURLRequest::FrameType frameType)
+RespondWithObserver* RespondWithObserver::create(ExecutionContext* context, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode requestMode, WebURLRequest::FrameType frameType)
 {
-    return new RespondWithObserver(context, eventID, requestMode, frameType);
+    return new RespondWithObserver(context, eventID, requestURL, requestMode, frameType);
 }
 
 void RespondWithObserver::contextDestroyed()
 {
     ContextLifecycleObserver::contextDestroyed();
     m_state = Done;
 }
 
 void RespondWithObserver::didDispatchEvent(bool defaultPrevented)
 {
@@ skipping 19 matching lines @@
 
     m_state = Pending;
     ScriptPromise::cast(scriptState, value).then(
         ThenFunction::createFunction(scriptState, this, ThenFunction::Fulfilled),
         ThenFunction::createFunction(scriptState, this, ThenFunction::Rejected));
 }
 
 void RespondWithObserver::responseWasRejected(WebServiceWorkerResponseError error)
 {
     ASSERT(executionContext());
+    maybeOutputErrorMessage(executionContext(), error, m_requestURL);
     // The default value of WebServiceWorkerResponse's status is 0, which maps
     // to a network error.
     WebServiceWorkerResponse webResponse;
     webResponse.setError(error);
     ServiceWorkerGlobalScopeClient::from(executionContext())->didHandleFetchEvent(m_eventID, webResponse);
     m_state = Done;
 }
 
 void RespondWithObserver::responseWasFulfilled(const ScriptValue& value)
 {
@@ skipping 43 matching lines @@
         buffer->startLoading(loader, nullptr);
         m_state = Done;
         return;
     }
     WebServiceWorkerResponse webResponse;
     response->populateWebServiceWorkerResponse(webResponse);
     ServiceWorkerGlobalScopeClient::from(executionContext())->didHandleFetchEvent(m_eventID, webResponse);
     m_state = Done;
 }
 
-RespondWithObserver::RespondWithObserver(ExecutionContext* context, int eventID, WebURLRequest::FetchRequestMode requestMode, WebURLRequest::FrameType frameType)
+RespondWithObserver::RespondWithObserver(ExecutionContext* context, int eventID, const KURL& requestURL, WebURLRequest::FetchRequestMode requestMode, WebURLRequest::FrameType frameType)
     : ContextLifecycleObserver(context)
     , m_eventID(eventID)
+    , m_requestURL(requestURL)
     , m_requestMode(requestMode)
     , m_frameType(frameType)
     , m_state(Initial)
 {
 }
 
 DEFINE_TRACE(RespondWithObserver)
 {
     ContextLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink