Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: chrome/browser/ui/toolbar/component_toolbar_actions_browsertest.cc

Issue 1228223002: Close wrench menu when Media Router Action clicked in Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/component_toolbar_actions_factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/memory/scoped_ptr.h" 6 #include "base/memory/scoped_ptr.h"
7 #include "chrome/browser/extensions/browser_action_test_util.h" 7 #include "chrome/browser/extensions/browser_action_test_util.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h" 9 #include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"
10 #include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h" 10 #include "chrome/browser/ui/toolbar/test_toolbar_action_view_controller.h"
11 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h" 11 #include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
12 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h" 12 #include "chrome/browser/ui/toolbar/toolbar_actions_bar.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 #include "extensions/common/feature_switch.h" 14 #include "extensions/common/feature_switch.h"
15 15
16 namespace { 16 namespace {
17 17
18 const char kMockId[] = "mock_action"; 18 const char kMockId[] = "mock_action";
19 19
20 class MockComponentToolbarActionsFactory 20 class MockComponentToolbarActionsFactory
21 : public ComponentToolbarActionsFactory { 21 : public ComponentToolbarActionsFactory {
22 public: 22 public:
23 MockComponentToolbarActionsFactory(); 23 explicit MockComponentToolbarActionsFactory(Browser* browser);
24 virtual ~MockComponentToolbarActionsFactory(); 24 virtual ~MockComponentToolbarActionsFactory();
25 25
26 // ComponentToolbarActionsFactory: 26 // ComponentToolbarActionsFactory:
27 ScopedVector<ToolbarActionViewController> GetComponentToolbarActions() 27 ScopedVector<ToolbarActionViewController>
28 override; 28 GetComponentToolbarActions(Browser* browser) override;
29 29
30 const std::vector<std::string> action_ids() const { 30 const std::vector<std::string> action_ids() const {
31 return action_ids_; 31 return action_ids_;
32 } 32 }
33 33
34 private: 34 private:
35 // A set of all action ids of created actions. 35 // A set of all action ids of created actions.
36 std::vector<std::string> action_ids_; 36 std::vector<std::string> action_ids_;
37 37
38 DISALLOW_COPY_AND_ASSIGN(MockComponentToolbarActionsFactory); 38 DISALLOW_COPY_AND_ASSIGN(MockComponentToolbarActionsFactory);
39 }; 39 };
40 40
41 MockComponentToolbarActionsFactory::MockComponentToolbarActionsFactory() { 41 MockComponentToolbarActionsFactory::MockComponentToolbarActionsFactory(
42 Browser* browser) {
42 ComponentToolbarActionsFactory::SetTestingFactory(this); 43 ComponentToolbarActionsFactory::SetTestingFactory(this);
43 44
44 ScopedVector<ToolbarActionViewController> actions = 45 ScopedVector<ToolbarActionViewController> actions =
45 GetComponentToolbarActions(); 46 GetComponentToolbarActions(browser);
46 for (auto it = actions.begin(); it != actions.end(); ++it) { 47 for (auto it = actions.begin(); it != actions.end(); ++it) {
47 action_ids_.push_back((*it)->GetId()); 48 action_ids_.push_back((*it)->GetId());
48 } 49 }
49 } 50 }
50 51
51 MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() { 52 MockComponentToolbarActionsFactory::~MockComponentToolbarActionsFactory() {
52 ComponentToolbarActionsFactory::SetTestingFactory(nullptr); 53 ComponentToolbarActionsFactory::SetTestingFactory(nullptr);
53 } 54 }
54 55
55 ScopedVector<ToolbarActionViewController> 56 ScopedVector<ToolbarActionViewController>
56 MockComponentToolbarActionsFactory::GetComponentToolbarActions() { 57 MockComponentToolbarActionsFactory::GetComponentToolbarActions(
58 Browser* browser) {
57 ScopedVector<ToolbarActionViewController> component_actions; 59 ScopedVector<ToolbarActionViewController> component_actions;
58 TestToolbarActionViewController* action = 60 TestToolbarActionViewController* action =
59 new TestToolbarActionViewController(kMockId); 61 new TestToolbarActionViewController(kMockId);
60 component_actions.push_back(action); 62 component_actions.push_back(action);
61 return component_actions.Pass(); 63 return component_actions.Pass();
62 } 64 }
63 65
64 } // namespace 66 } // namespace
65 67
66 class ComponentToolbarActionsBrowserTest : public InProcessBrowserTest { 68 class ComponentToolbarActionsBrowserTest : public InProcessBrowserTest {
67 protected: 69 protected:
68 ComponentToolbarActionsBrowserTest() {} 70 ComponentToolbarActionsBrowserTest() {}
69 ~ComponentToolbarActionsBrowserTest() override {} 71 ~ComponentToolbarActionsBrowserTest() override {}
70 72
71 void SetUpCommandLine(base::CommandLine* command_line) override { 73 void SetUpCommandLine(base::CommandLine* command_line) override {
72 InProcessBrowserTest::SetUpCommandLine(command_line); 74 InProcessBrowserTest::SetUpCommandLine(command_line);
73 enable_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride( 75 enable_redesign_.reset(new extensions::FeatureSwitch::ScopedOverride(
74 extensions::FeatureSwitch::extension_action_redesign(), true)); 76 extensions::FeatureSwitch::extension_action_redesign(), true));
75 mock_actions_factory_.reset(new MockComponentToolbarActionsFactory()); 77 mock_actions_factory_.reset(new MockComponentToolbarActionsFactory(
78 browser()));
76 } 79 }
77 80
78 MockComponentToolbarActionsFactory* mock_factory() { 81 MockComponentToolbarActionsFactory* mock_factory() {
79 return mock_actions_factory_.get(); 82 return mock_actions_factory_.get();
80 } 83 }
81 84
82 private: 85 private:
83 scoped_ptr<extensions::FeatureSwitch::ScopedOverride> enable_redesign_; 86 scoped_ptr<extensions::FeatureSwitch::ScopedOverride> enable_redesign_;
84 scoped_ptr<MockComponentToolbarActionsFactory> mock_actions_factory_; 87 scoped_ptr<MockComponentToolbarActionsFactory> mock_actions_factory_;
85 88
(...skipping 21 matching lines...) Expand all
107 browser_actions_bar.GetToolbarActionsBar()->GetActions(); 110 browser_actions_bar.GetToolbarActionsBar()->GetActions();
108 TestToolbarActionViewController* mock_component_action = 111 TestToolbarActionViewController* mock_component_action =
109 static_cast<TestToolbarActionViewController* const>(actions[0]); 112 static_cast<TestToolbarActionViewController* const>(actions[0]);
110 ASSERT_TRUE(mock_component_action); 113 ASSERT_TRUE(mock_component_action);
111 114
112 // Test that clicking on the component action works. 115 // Test that clicking on the component action works.
113 EXPECT_EQ(0, mock_component_action->execute_action_count()); 116 EXPECT_EQ(0, mock_component_action->execute_action_count());
114 browser_actions_bar.Press(0); 117 browser_actions_bar.Press(0);
115 EXPECT_EQ(1, mock_component_action->execute_action_count()); 118 EXPECT_EQ(1, mock_component_action->execute_action_count());
116 } 119 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/component_toolbar_actions_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698