chrome/browser/ui/toolbar/media_router_action_platform_delegate.h - Issue 1228223002: Close wrench menu when Media Router Action clicked in Views.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/toolbar/media_router_action_platform_delegate.h

Issue 1228223002: Close wrench menu when Media Router Action clicked in Views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/toolbar/media_router_action.cc ('K') | « chrome/browser/ui/toolbar/media_router_action.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.cc » ('j') | chrome/browser/ui/views/toolbar/media_router_action_platform_delegate_views.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_PLATFORM_DELEGATE_H_

	6 #define CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_PLATFORM_DELEGATE_H_

	7

	8 #include "base/memory/scoped_ptr.h"

	9 #include "chrome/browser/ui/browser.h"
	Devlin 2015/07/14 17:23:02 Forward declaration works. Forward declaration works. apacible 2015/07/14 21:15:23 Done. Show quoted text On 2015/07/14 17:23:02, Devlin wrote: > Forward declaration works. Done.
	10

	11 class MediaRouterActionPlatformDelegate {

	12 public:

	13 virtual ~MediaRouterActionPlatformDelegate() {}

	14

	15 // Returns a created MediaRouterActionPlatformDelegate. This is defined in the

	16 // platform-specific implementation for the class.

	17 static scoped_ptr<MediaRouterActionPlatformDelegate> Create(Browser* browser);

	18

	19 // Closes the overflow menu, if it was open.
	Devlin 2015/07/14 17:23:02 The comment is good, but I'd rename the method to The comment is good, but I'd rename the method to be CloseOverflowMenuIfOpen() just to make it clear when reading the code. apacible 2015/07/14 21:15:23 Done. Show quoted text On 2015/07/14 17:23:02, Devlin wrote: > The comment is good, but I'd rename the method to be CloseOverflowMenuIfOpen() > just to make it clear when reading the code. Done.
	20 virtual void CloseOverflowMenu() = 0;

	21 };

	22

	23 #endif // CHROME_BROWSER_UI_TOOLBAR_MEDIA_ROUTER_ACTION_PLATFORM_DELEGATE_VIEWS _H_

OLD	NEW