ui/views/controls/button/label_button.h - Issue 1228213003: Just set borders once when creating a views::LabelButton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/label_button.h

Issue 1228213003: Just set borders once when creating a views::LabelButton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: self review Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc ('K') | « ui/views/controls/button/blue_button_unittest.cc ('k') | ui/views/controls/button/label_button.cc » ('j') | ui/views/controls/button/label_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/button/label_button.h

diff --git a/ui/views/controls/button/label_button.h b/ui/views/controls/button/label_button.h

index 2efd5b11f7d273e19eba4cdc95bbac37e5f4eee5..e867852db372450b6167de7d22d920f1f85f3109 100644

--- a/ui/views/controls/button/label_button.h

+++ b/ui/views/controls/button/label_button.h

@@ -38,7 +38,7 @@ class VIEWS_EXPORT LabelButton : public CustomButton,

// Get or set the text shown on the button.

const base::string16& GetText() const;

- virtual void SetText(const base::string16& text);

+ void SetText(const base::string16& text);

// Set the text color shown for the specified button state.

void SetTextColor(ButtonState for_state, SkColor color);