Just set borders once when creating a views::LabelButton

chrome/test/base/view_event_test_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/view_event_test_base.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "chrome/test/base/chrome_unit_test_suite.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/view_event_test_platform_part.h"
 #include "ui/base/ime/input_method_initializer.h"
 #include "ui/base/test/ui_controls.h"
 #include "ui/compositor/test/context_factories_for_test.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace {
 
 // View subclass that allows you to specify the preferred size.
 class TestView : public views::View {
  public:
-  TestView() {}
-
-  void SetPreferredSize(const gfx::Size& size) {
-    preferred_size_ = size;
-    PreferredSizeChanged();
-  }
+  explicit TestView(ViewEventTestBase* harness) : harness_(harness) {}
 
   gfx::Size GetPreferredSize() const override {
-    if (!preferred_size_.IsEmpty())
-      return preferred_size_;
-    return View::GetPreferredSize();
+    return harness_->GetPreferredSize();
   }
 
   void Layout() override {
     View* child_view = child_at(0);
     child_view->SetBounds(0, 0, width(), height());
   }
 
  private:
-  gfx::Size preferred_size_;
+  ViewEventTestBase* harness_;
 
   DISALLOW_COPY_AND_ASSIGN(TestView);
 };
 
 // Delay in background thread before posting mouse move.
 const int kMouseMoveDelayMS = 200;
 
 }  // namespace
 
 ViewEventTestBase::ViewEventTestBase()
@@ skipping 37 matching lines @@
   }
 
   ui::Clipboard::DestroyClipboardForCurrentThread();
   platform_part_.reset();
 
   ui::TerminateContextFactoryForTests();
 
   ui::ShutdownInputMethodForTesting();
 }
 
+gfx::Size ViewEventTestBase::GetPreferredSize() const {
+  return gfx::Size();
+}
+
 bool ViewEventTestBase::CanResize() const {
   return true;
 }
 
 views::View* ViewEventTestBase::GetContentsView() {
   if (!content_view_) {
     // Wrap the real view (as returned by CreateContentsView) in a View so
     // that we can customize the preferred size.
-    TestView* test_view = new TestView();
-    test_view->SetPreferredSize(GetPreferredSize());
+    TestView* test_view = new TestView(this);
     test_view->AddChildView(CreateContentsView());
     content_view_ = test_view;
   }
   return content_view_;
 }
 
 const views::Widget* ViewEventTestBase::GetWidget() const {
   return content_view_->GetWidget();
 }
 
@@ skipping 13 matching lines @@
   content::RunAllPendingInMessageLoop();
 
   // Schedule a task that starts the test. Need to do this as we're going to
   // run the message loop.
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(&ViewEventTestBase::DoTestOnMessageLoop, this));
 
   content::RunThisRunLoop(&run_loop_);
 }
 
-gfx::Size ViewEventTestBase::GetPreferredSize() const {
-  return gfx::Size();
-}
-
 void ViewEventTestBase::ScheduleMouseMoveInBackground(int x, int y) {
   if (!dnd_thread_.get()) {
     dnd_thread_.reset(new base::Thread("mouse-move-thread"));
     dnd_thread_->Start();
   }
   dnd_thread_->task_runner()->PostDelayedTask(
       FROM_HERE,
       base::Bind(base::IgnoreResult(&ui_controls::SendMouseMove), x, y),
       base::TimeDelta::FromMilliseconds(kMouseMoveDelayMS));
 }
 
 void ViewEventTestBase::StopBackgroundThread() {
   dnd_thread_.reset(NULL);
 }
 
 void ViewEventTestBase::RunTestMethod(const base::Closure& task) {
   StopBackgroundThread();
 
   task.Run();
   if (HasFatalFailure())
     Done();
 }