Issue 12282042: Merge 182615

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12282042: Merge 182615 (Closed)

Created:
7 years, 10 months ago by Yoyo Zhou

Modified:
7 years, 10 months ago

Reviewers:
mhx348, Joe Thomas

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

Merge 182615 > Fix a bug where extensions created with locale info from the command line is broken. > > Register the ManifestHandler for default_locale > > BUG=176187 > TEST=1. Unzip the test.zip attachment from issue 176187. > 2. Use chrome to pack it as an extension (chrome --pack-extension=test). > test.crx should be created successfully. > > Review URL: https://chromiumcodereview.appspot.com/12256041 TBR=MHX348@motorola.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183250

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/browser/extensions/startup_helper.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

LGTM. Thanks :)