[content shell] implement pathToLocalResource

content/shell/webkit_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/webkit_test_runner.h"
 
+#include <algorithm>
+#include <cctype>
 #include <clocale>
 #include <cmath>
 
 #include "base/base64.h"
 #include "base/debug/debugger.h"
 #include "base/md5.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/stringprintf.h"
 #include "base/sys_string_conversions.h"
@@ skipping 280 matching lines @@
 void WebKitTestRunner::setFocus(bool focus) {
   Send(new ShellViewHostMsg_NotImplemented(
       routing_id(), "WebKitTestRunner", "setFocus"));
 }
 
 void WebKitTestRunner::setAcceptAllCookies(bool accept) {
   Send(new ShellViewHostMsg_AcceptAllCookies(routing_id(), accept));
 }
 
 std::string WebKitTestRunner::pathToLocalResource(const std::string& resource) {
-  Send(new ShellViewHostMsg_NotImplemented(
-      routing_id(), "WebKitTestRunner", "pathToLocalResource"));
-  return std::string();
+#if defined(OS_WIN)
+  if (resource.find("/tmp/")) {

[Nico, 2013/02/19 16:02:53]

.find("/tmp/") == 0?

(or indexof() instead of find(); there's some function which gives you the index
i think)

[jochen (gone - plz use gerrit), 2013/02/20 09:06:13]

Done.

+    // We want a temp file.
+    const unsigned kTempPrefixLength = 5;

[Nico, 2013/02/19 16:02:53]

strlen("/tmp") instead of 5

[jochen (gone - plz use gerrit), 2013/02/20 09:06:13]

Done.

+    GURL base_url = net::FilePathToFileURL(temp_path_);
+    return base_url.Resolve(resource.substr(kTempPrefixLength)).spec();

[Nico, 2013/02/19 15:51:50]

Hm, is there code for this somewhere else already? This looks like something
that's probably been implemented many times?

[jochen (gone - plz use gerrit), 2013/02/20 09:06:13]

nope

+  }
+#endif
+
+  // Some layout tests use file://// which we resolve as a UNC path. Normalize
+  // them to just file:///.
+  std::string lower_url = resource;
+  std::string result = resource;
+  std::transform(
+      lower_url.begin(), lower_url.end(), lower_url.begin(), tolower);

[Nico, 2013/02/19 16:02:53]

StringToLowerASCII?

+  while (!lower_url.find("file:////")) {

[Nico, 2013/02/19 16:02:53]

Probably simpler if you create a new temporary each time instead of keeping two
up to date?


while (StringToLowerASCII(string(resource).find("file:////") == 0)
   substr

[jochen (gone - plz use gerrit), 2013/02/20 09:06:13]

Done.

+      result = result.substr(0, 8) + result.substr(9);
+      lower_url = lower_url.substr(0, 8) + lower_url.substr(9);
+  }
+  return rewriteLayoutTestsURL(result).spec();
 }
 
 void WebKitTestRunner::setLocale(const std::string& locale) {
   setlocale(LC_ALL, locale.c_str());
 }
 
 void WebKitTestRunner::setDeviceOrientation(WebDeviceOrientation& orientation) {
   Send(new ShellViewHostMsg_NotImplemented(
       routing_id(), "WebKitTestRunner", "setDeviceOrientation"));
 }
@@ skipping 237 matching lines @@
           routing_id(), actual_pixel_hash, snapshot));
     }
   }
 
   Send(new ShellViewHostMsg_TestFinished(routing_id(), false));
 }
 
 void WebKitTestRunner::OnSetTestConfiguration(
     const ShellViewMsg_SetTestConfiguration_Params& params) {
   current_working_directory_ = params.current_working_directory;
+  temp_path_ = params.temp_path;
   enable_pixel_dumping_ = params.enable_pixel_dumping;
   layout_test_timeout_ = params.layout_test_timeout;
   allow_external_pages_ = params.allow_external_pages;
   expected_pixel_hash_ = params.expected_pixel_hash;
   is_main_window_ = true;
 
   WebTestInterfaces* interfaces =
       ShellRenderProcessObserver::GetInstance()->test_interfaces();
   interfaces->setTestIsRunning(true);
   interfaces->configureForTestWithURL(params.test_url, enable_pixel_dumping_);
 }
 
 }  // namespace content