Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: samples/third_party/dromaeo/common/BenchUtil.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/intermediate_language.h ('K') | « samples/swarm/swarm_ui_lib/layout/GridTracks.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: samples/third_party/dromaeo/common/BenchUtil.dart
diff --git a/samples/third_party/dromaeo/common/BenchUtil.dart b/samples/third_party/dromaeo/common/BenchUtil.dart
index 3388980f751ddf3ff4d57dd724d7a167bfff4085..04520461e6056a2d3675e612052a920b9736a4ec 100644
--- a/samples/third_party/dromaeo/common/BenchUtil.dart
+++ b/samples/third_party/dromaeo/common/BenchUtil.dart
@@ -39,7 +39,7 @@ class BenchUtil {
}
static bool _inRange(int charCode, String start, String end) {
- return start.charCodeAt(0) <= charCode && charCode <= end.charCodeAt(0);
+ return start.codeUnitAt(0) <= charCode && charCode <= end.codeUnitAt(0);
}
static const String DIGITS = '0123456789ABCDEF';
@@ -50,7 +50,7 @@ class BenchUtil {
static String encodeUri(final String s) {
StringBuffer sb = new StringBuffer();
for (int i = 0; i < s.length; i++) {
- final int charCode = s.charCodeAt(i);
+ final int charCode = s.codeUnitAt(i);
final bool noEscape =
_inRange(charCode, '0', '9') ||
_inRange(charCode, 'a', 'z') ||
« runtime/vm/intermediate_language.h ('K') | « samples/swarm/swarm_ui_lib/layout/GridTracks.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698