runtime/vm/intrinsifier_ia32.cc - Issue 12282038: Remove deprecated string features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index b939f783ec7cd54373fb4135412623b2b87e8b72..3522faa3d2a93d9b35df92b885017e0c4f2eba81 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -1838,7 +1838,7 @@ bool Intrinsifier::String_getLength(Assembler* assembler) {

// TODO(srdjan): Implement for two and four byte strings as well.

-bool Intrinsifier::String_charCodeAt(Assembler* assembler) {

+bool Intrinsifier::String_codeUnitAt(Assembler* assembler) {

Label fall_through;

__ movl(EBX, Address(ESP, + 1 * kWordSize)); // Index.

__ movl(EAX, Address(ESP, + 2 * kWordSize)); // String.