Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: utils/template/codegen.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tests/corelib/collection_to_string_test.dart ('K') | « utils/pub/utils.dart ('k') | utils/template/tokenizer.dart » ('j') | utils/tests/string_encoding/unicode_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/template/codegen.dart
diff --git a/utils/template/codegen.dart b/utils/template/codegen.dart
index 6f566a6db14d9a020bd9b986586f0e8fe85d064e..5d8ed2f944e63e51a7e02e8d9af275faca8005b2 100644
--- a/utils/template/codegen.dart
+++ b/utils/template/codegen.dart
@@ -757,7 +757,7 @@ Nested #each or #with must have a localName;
bool identifier = true;
if (m.start > 0) {
- int charCode = expr.charCodeAt(m.start - 1);
+ int charCode = expr.codeUnitAt(m.start - 1);
// Starts with ' or " then it's not an identifier.
identifier = charCode != 34 /* " */ && charCode != 39 /* ' */;
}
« tests/corelib/collection_to_string_test.dart ('K') | « utils/pub/utils.dart ('k') | utils/template/tokenizer.dart » ('j') | utils/tests/string_encoding/unicode_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698