Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: base/file_path.h

Issue 12282019: Disable "using base::FilePath" on Linux since it now compiles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/base_paths_mac.mm ('k') | base/file_util_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // FilePath is a container for pathnames stored in a platform's native string 5 // FilePath is a container for pathnames stored in a platform's native string
6 // type, providing containers for manipulation in according with the 6 // type, providing containers for manipulation in according with the
7 // platform's conventions for pathnames. It supports the following path 7 // platform's conventions for pathnames. It supports the following path
8 // types: 8 // types:
9 // 9 //
10 // POSIX Windows 10 // POSIX Windows
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 // directory, so "////" will become "/", not "". A leading pair of 395 // directory, so "////" will become "/", not "". A leading pair of
396 // separators is never stripped, to support alternate roots. This is used to 396 // separators is never stripped, to support alternate roots. This is used to
397 // support UNC paths on Windows. 397 // support UNC paths on Windows.
398 void StripTrailingSeparatorsInternal(); 398 void StripTrailingSeparatorsInternal();
399 399
400 StringType path_; 400 StringType path_;
401 }; 401 };
402 402
403 } // namespace base 403 } // namespace base
404 404
405 // TODO(brettw) remove this once callers properly use the base namespace. 405 // Temporarily have non-Linux platforms use a "using" so we can convert those
406 // over one-at-a-time.
407 //
408 // http://crosbug.com/39008 MTPD has a circular dependency on base and uses the
409 // old non-namespaced FilePath.
410 #if defined(MTPD_DEVICE_MANAGER_H_) || defined(OS_CHROMEOS) || \
411 !defined(OS_LINUX)
406 using base::FilePath; 412 using base::FilePath;
413 #endif
407 414
408 // This is required by googletest to print a readable output on test failures. 415 // This is required by googletest to print a readable output on test failures.
409 BASE_EXPORT extern void PrintTo(const base::FilePath& path, std::ostream* out); 416 BASE_EXPORT extern void PrintTo(const base::FilePath& path, std::ostream* out);
410 417
411 // Macros for string literal initialization of FilePath::CharType[], and for 418 // Macros for string literal initialization of FilePath::CharType[], and for
412 // using a FilePath::CharType[] in a printf-style format string. 419 // using a FilePath::CharType[] in a printf-style format string.
413 #if defined(OS_POSIX) 420 #if defined(OS_POSIX)
414 #define FILE_PATH_LITERAL(x) x 421 #define FILE_PATH_LITERAL(x) x
415 #define PRFilePath "s" 422 #define PRFilePath "s"
416 #define PRFilePathLiteral "%s" 423 #define PRFilePathLiteral "%s"
(...skipping 19 matching lines...) Expand all
436 443
437 inline size_t hash_value(const base::FilePath& f) { 444 inline size_t hash_value(const base::FilePath& f) {
438 return hash_value(f.value()); 445 return hash_value(f.value());
439 } 446 }
440 447
441 #endif // COMPILER 448 #endif // COMPILER
442 449
443 } // namespace BASE_HASH_NAMESPACE 450 } // namespace BASE_HASH_NAMESPACE
444 451
445 #endif // BASE_FILE_PATH_H_ 452 #endif // BASE_FILE_PATH_H_
OLDNEW
« no previous file with comments | « base/base_paths_mac.mm ('k') | base/file_util_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698