Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 12282018: Fix android envsetup permission issue. (Closed)

Created:
7 years, 10 months ago by Isaac (away)
Modified:
7 years, 9 months ago
Reviewers:
Yaron, Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Fix android envsetup permission issue. CQ automatically adds +x to any file which ends with .sh Since envsetup.sh doesn't have a shabang line, this has causes several tree closures. Fix this by adding a shabang and detecting when script is not being sourced. TBR=yfriedman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M envsetup.sh View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Isaac (away)
7 years, 10 months ago (2013-02-16 11:26:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/12282018/1
7 years, 10 months ago (2013-02-16 11:27:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/12282018/1
7 years, 10 months ago (2013-02-16 11:29:09 UTC) #3
Yaron
lgtm
7 years, 10 months ago (2013-02-19 16:51:09 UTC) #4
Nico
The webkit chromium/android builder has been failing ever since this made it into chromium: http://build.webkit.org/builders/Chromium%20Android%20Release/builds/34535/steps/gclient/logs/stdio ...
7 years, 10 months ago (2013-02-25 20:14:25 UTC) #5
Nico
*made it into webkit
7 years, 10 months ago (2013-02-25 20:14:37 UTC) #6
Isaac (away)
I had some trouble reproducing (and initially suspected the way gyp_webkit sources bash), but after ...
7 years, 9 months ago (2013-02-27 07:04:44 UTC) #7
Isaac (away)
7 years, 9 months ago (2013-02-27 07:08:05 UTC) #8
Message was sent while issue was closed.
* the way gyp_webkit sources envsetup.sh

Powered by Google App Engine
This is Rietveld 408576698