chrome/browser/autofill/autofill_manager_unittest.cc - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager_unittest.cc

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Autofill nits Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/testshell/java/AndroidManifest.xml ('K') | « chrome/browser/autofill/autofill_manager.cc ('k') | chrome/browser/autofill/auxiliary_profile_impl_unittest.cc » ('j') | chrome/browser/autofill/auxiliary_profile_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_manager_unittest.cc

diff --git a/chrome/browser/autofill/autofill_manager_unittest.cc b/chrome/browser/autofill/autofill_manager_unittest.cc

index b730e49e243f5917952da6e9865efe57c6d16434..69e67e1f15c8ebcba9014cb6cbbf85c52008c224 100644

--- a/chrome/browser/autofill/autofill_manager_unittest.cc

+++ b/chrome/browser/autofill/autofill_manager_unittest.cc

@@ -2703,9 +2703,10 @@ TEST_F(AutofillManagerTest, FormSubmittedWithDefaultValues) {

// thing on all platforms.

TEST_F(AutofillManagerTest, AuxiliaryProfilesReset) {

PrefService* prefs = PrefServiceFromBrowserContext(profile());

-#if defined(OS_MACOSX)

- // Auxiliary profiles is implemented on Mac only. It enables Mac Address

- // Book integration.

+#if defined(OS_MACOSX) || defined(OS_ANDROID)

+ // Auxiliary profiles is implemented on Mac and Android only.

+ // OSX: enables Mac Address Book integration.

+ // Android: enables integration with user's contact profile.

ASSERT_TRUE(prefs->GetBoolean(prefs::kAutofillAuxiliaryProfilesEnabled));

prefs->SetBoolean(prefs::kAutofillAuxiliaryProfilesEnabled, false);

prefs->ClearPref(prefs::kAutofillAuxiliaryProfilesEnabled);