chrome/browser/autofill/personal_data_manager.cc - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/personal_data_manager.cc

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_manager_unittest.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/autofill/personal_data_manager_android.h » ('j') | chrome/browser/autofill/personal_data_manager_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/personal_data_manager.cc

diff --git a/chrome/browser/autofill/personal_data_manager.cc b/chrome/browser/autofill/personal_data_manager.cc

index df49ded7237381f77f8561e0c597f52e14bb4024..831428929fa7eb80a22b6f0bb6036f351adf5187 100644

--- a/chrome/browser/autofill/personal_data_manager.cc

+++ b/chrome/browser/autofill/personal_data_manager.cc

@@ -869,9 +869,9 @@ void PersonalDataManager::LoadProfiles() {

pending_profiles_query_ = autofill_data->GetAutofillProfiles(this);

}

-// Win and Linux implementations do nothing. Mac implementation fills in the

-// contents of |auxiliary_profiles_|.

-#if !defined(OS_MACOSX)

+// Win and Linux implementations do nothing. Mac

aurimas (slooooooooow) 2013/02/15 19:08:35 Why break the line is such a weird place?

apiccion 2013/02/26 23:51:51 Done.

+// and Android implementation fills in the contents of |auxiliary_profiles_|.

Ilya Sherman 2013/02/16 04:14:37 nit: "implementation fills" -> "implementations fi

David Trainor- moved to gerrit 2013/02/19 19:03:13 implementations fill?

apiccion 2013/02/26 23:51:51 Done.

+#if !defined(OS_MACOSX) && !defined(OS_ANDROID)

void PersonalDataManager::LoadAuxiliaryProfiles() {

}

#endif