chrome/browser/autofill/auxiliary_profiles_android.h - Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

Side by Side Diff: chrome/browser/autofill/auxiliary_profiles_android.h

Issue 12282004: Added personal_data_manager android implementation for auto-populating auto-fill on android builds … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Autofill nits Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/autofill/auxiliary_profile_loader_mock.cc ('K') | « chrome/browser/autofill/auxiliary_profile_loader_mock.cc ('k') | chrome/browser/autofill/auxiliary_profiles_android.cc » ('j') | chrome/browser/autofill/auxiliary_profiles_android.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILES_ANDROID_H_

	6 #define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILES_ANDROID_H_

	7

	8 #include <jni.h>
	Ilya Sherman 2013/03/01 01:55:04 nit: Please leave a blank line after this one. nit: Please leave a blank line after this one. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Please leave a blank line after this one. Done.
	9 #include "base/guid.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: This doesn't seem to be used. nit: This doesn't seem to be used. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: This doesn't seem to be used. Done.
	10 #include "base/logging.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: This doesn't seem to be used. nit: This doesn't seem to be used. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: This doesn't seem to be used. Done.
	11 #include "base/memory/scoped_ptr.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: This doesn't seem to be used. nit: This doesn't seem to be used. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: This doesn't seem to be used. Done.
	12 #include "base/memory/scoped_vector.h"

	13 #include "base/string16.h"

	14 #include "base/utf_string_conversions.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: This doesn't seem to be used. nit: This doesn't seem to be used. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: This doesn't seem to be used. Done.
	15 #include "chrome/browser/autofill/autofill_profile.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: Forward-declare. nit: Forward-declare. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Forward-declare. Done.
	16 #include "chrome/browser/autofill/auxiliary_profile_loader.h"
	Ilya Sherman 2013/03/01 01:55:04 nit: Forward-declare. nit: Forward-declare. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Forward-declare. Done.
	17

	18 class AuxiliaryProfilesAndroid {
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	19 public:

	20 AuxiliaryProfilesAndroid(ScopedVector<AutofillProfile>* profiles,
	Ilya Sherman 2013/03/01 01:55:04 You should never pass in a ScopedVector to a metho You should never pass in a ScopedVector to a method. This should almost certainly be a "const std::vector<AutofillProfile>& profiles". Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	21 AuxiliaryProfileLoader* profileLoader);

	22

	23 void GetContactsProfile();
	Ilya Sherman 2013/03/01 01:55:04 nit: Docs. nit: Docs. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Docs. Done.
	24

	25 private:

	26 string16 CollapseAddress(string16 pobox,

	27 string16 neighborhood);
	Ilya Sherman 2013/03/01 01:55:04 nit: Pass strings by const-reference, not by value nit: Pass strings by const-reference, not by value. Ilya Sherman 2013/03/01 01:55:04 nit: Docs. (Applies throughout.) nit: Docs. (Applies throughout.) apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Pass strings by const-reference, not by value. Done.
	28 void LoadAddress(AutofillProfile* profile);
	Ilya Sherman 2013/03/01 01:55:04 nit: Pass by const-reference? nit: Pass by const-reference? apiccion 2013/03/02 03:37:01 These methods mutate their argument. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > nit: Pass by const-reference? These methods mutate their argument.
	29 void LoadName(AutofillProfile* profile);

	30 void LoadEmailAddress(AutofillProfile* profile);

	31 void LoadPhoneNumbers(AutofillProfile* profile);

	32

	33 ScopedVector<AutofillProfile>& profiles_;

	34 AuxiliaryProfileLoader& profile_loader_;
	Ilya Sherman 2013/03/01 01:55:04 You should pretty much never store non-const refer You should pretty much never store non-const references. Either create copies or store as pointers, depending on what's appropriate. apiccion 2013/03/02 03:37:01 Done. Show quoted text On 2013/03/01 01:55:04, Ilya Sherman wrote: > You should pretty much never store non-const references. Either create copies > or store as pointers, depending on what's appropriate. Done.
	35

	36 DISALLOW_COPY_AND_ASSIGN(AuxiliaryProfilesAndroid);

	37 };

	38

	39 #endif // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILES_ANDROID_H_

OLD	NEW