Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/auxiliary_profile_loader_impl_android.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/autofill/auxiliary_profile_loader_impl_android.h"
+
+#include <vector>

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Leave a blank line after this one.

[apiccion, 2013/03/02 03:37:01]

Done.

+#include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
+#include "base/android/jni_local_ref_extensions.h"
+#include "base/android/jni_string.h"
+#include "jni/PersonalAutofillPopulator_jni.h"
+
+#define JM(__jmethod__) Java_PersonalAutofillPopulator_##__jmethod__(env_,\
+                         populator_.obj())

[Ilya Sherman, 2013/03/01 01:55:04]

nit: Please don't use abbreviations in code.  If you really want to define a
macro like this, at least name it something like JAVA_METHOD.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+using namespace base::android;

[Ilya Sherman, 2013/03/01 01:55:04]

nit: "using namespace" is disallowed by the style guide.  Something like "using
base::android::SomeAndroidOnlyClass" is allowed, though.

[apiccion, 2013/03/02 03:37:01]

Done.

+
+bool RegisterAuxiliaryProfileLoader(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}
+
+AuxiliaryProfileLoaderImplAndroid::AuxiliaryProfileLoaderImplAndroid() {
+  env_ = base::android::AttachCurrentThread();
+  populator_ = Java_PersonalAutofillPopulator_create(env_,
+                base::android::GetApplicationContext());

[Ilya Sherman, 2013/03/01 01:55:04]

nit: The indentation is off here.

[Ilya Sherman, 2013/03/01 01:55:04]

Any reason why you can't do these initializations in the initializer list?

[apiccion, 2013/03/02 03:37:01]

Done.

[apiccion, 2013/03/02 03:37:01]

Done.

+}
+
+// Address info
+string16 AuxiliaryProfileLoaderImplAndroid::GetStreet() {
+  return SafeJavaStringToUTF16(JM(getStreet));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetPobox() {
+  return SafeJavaStringToUTF16(JM(getPobox));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetNeighborhood() {
+  return SafeJavaStringToUTF16(JM(getNeighborhood));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetRegion() {
+  return SafeJavaStringToUTF16(JM(getRegion));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetCity() {
+  return SafeJavaStringToUTF16(JM(getCity));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetPostalCode() {
+  return SafeJavaStringToUTF16(JM(getPostalCode));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetCountry() {
+  return SafeJavaStringToUTF16(JM(getCountry));
+}
+
+// Name info
+string16 AuxiliaryProfileLoaderImplAndroid::GetFirstName() {
+  return SafeJavaStringToUTF16(JM(getFirstName));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetMiddleName() {
+  return SafeJavaStringToUTF16(JM(getMiddleName));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetLastName() {
+  return SafeJavaStringToUTF16(JM(getLastName));
+}
+
+string16 AuxiliaryProfileLoaderImplAndroid::GetSuffix() {
+  return SafeJavaStringToUTF16(JM(getSuffix));
+}
+
+// Email info
+std::vector<string16> AuxiliaryProfileLoaderImplAndroid::GetEmailAddresses() {
+  return SafeJavaStringArrayToStringVector(JM(getEmailAddresses), env_);
+}
+
+// Phone info
+std::vector<string16> AuxiliaryProfileLoaderImplAndroid::GetPhoneNumbers() {
+  return SafeJavaStringArrayToStringVector(JM(getPhoneNumbers), env_);
+}