Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/i_auxiliary_profile_loader.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_I_AUXILIARY_PROFILE_LOADER_H_
+#define CHROME_BROWSER_AUTOFILL_I_AUXILIARY_PROFILE_LOADER_H_
+
+#include <vector>
+#include "base/string16.h"
+
+class IAuxiliaryProfileLoader {

[aurimas (slooooooooow), 2013/02/27 01:56:00]

Why does this class have I in the beginning of its name?

[apiccion, 2013/02/28 01:31:04]

Interface class. As per Dave's comment I've removed the I.

On 2013/02/27 01:56:00, aurimas wrote:

+ public:
+  virtual ~IAuxiliaryProfileLoader() {}
+
+  // Address info
+  virtual string16 GetStreet() = 0;

[aurimas (slooooooooow), 2013/02/27 01:56:00]

This should be called street() since it is a simple accessor.
See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[apiccion, 2013/02/28 01:31:04]

Abstract implementation. Not necessarily a simple mutator.

On 2013/02/27 01:56:00, aurimas wrote:

+  virtual string16 GetPobox() = 0;

[aurimas (slooooooooow), 2013/02/27 01:56:00]

Same for all the functions below.

[apiccion, 2013/02/28 01:31:04]

See above.
On 2013/02/27 01:56:00, aurimas wrote:

+  virtual string16 GetNeighborhood() = 0;
+  virtual string16 GetRegion() = 0;
+  virtual string16 GetCity() = 0;
+  virtual string16 GetPostalCode() = 0;
+  virtual string16 GetCountry() = 0;
+
+  // Name info
+  virtual string16 GetFirstName() = 0;
+  virtual string16 GetMiddleName() = 0;
+  virtual string16 GetLastName() = 0;
+  virtual string16 GetSuffix() = 0;
+
+  // Email info
+  virtual std::vector<string16> GetEmailAddresses() = 0;
+
+  // Phone info
+  virtual std::vector<string16> GetPhoneNumbers() = 0;
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_I_AUXILIARY_PROFILE_LOADER_H_