Added personal_data_manager android implementation for auto-populating auto-fill on android builds …

chrome/browser/autofill/auxiliary_profile_loader_mock.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_MOCK_H_
+#define CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_MOCK_H_
+
+#include "chrome/browser/autofill/i_auxiliary_profile_loader.h"
+
+class AuxiliaryProfileLoaderMock : public IAuxiliaryProfileLoader {
+ public:
+  explicit AuxiliaryProfileLoaderMock();
+
+  // Address info
+  virtual string16 GetStreet();
+  void SetStreet(string16);

[aurimas (slooooooooow), 2013/02/27 01:56:00]

This should be called set_street() since it is a simple setter.
See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

[apiccion, 2013/02/28 01:31:04]

Think this violates separation of interface from underlying implementation. It's
overriding methods in an abstract interface
(AuxiliaryProfileLoader/IAuxiliaryProfileLoader). Not sure.

On 2013/02/27 01:56:00, aurimas wrote:

+  virtual string16 GetPobox();
+  void SetPobox(string16);

[aurimas (slooooooooow), 2013/02/27 01:56:00]

Same for all the Set... functions below.

[apiccion, 2013/02/28 01:31:04]

See comment above.

+  virtual string16 GetNeighborhood();
+  void SetNeighborhood(string16);
+  virtual string16 GetRegion();
+  void SetRegion(string16);
+  virtual string16 GetCity();
+  void SetCity(string16);
+  virtual string16 GetPostalCode();
+  void SetPostalCode(string16);
+  virtual string16 GetCountry();
+  void SetCountry(string16);
+
+  // Name info
+  virtual string16 GetFirstName();
+  void SetFirstName(string16);
+  virtual string16 GetMiddleName();
+  void SetMiddleName(string16);
+  virtual string16 GetLastName();
+  void SetLastName(string16);
+  virtual string16 GetSuffix();
+  void SetSuffix(string16);
+
+  // Email info
+  virtual std::vector<string16> GetEmailAddresses();
+  void SetEmailAddresses(std::vector<string16>);
+
+  // Phone info
+  virtual std::vector<string16> GetPhoneNumbers();
+  void SetPhoneNumbers(std::vector<string16>);
+
+ private:
+  string16 street_;
+  string16 pobox_;
+  string16 neighborhood_;
+  string16 region_;
+  string16 city_;
+  string16 postalCode_;
+  string16 country_;
+  string16 firstName_;
+  string16 middleName_;
+  string16 lastName_;
+  string16 suffix_;
+  std::vector<string16> emailAddresses_;
+  std::vector<string16> phoneNumbers_;
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUXILIARY_PROFILE_LOADER_MOCK_H_