Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1228163005: Update some webui question mark icons to SVG. (Closed)

Created:
5 years, 5 months ago by Evan Stade
Modified:
5 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some webui question mark icons to SVG. BUG=505953 Committed: https://crrev.com/7eb865bd0a9db57cb55617da2c46e3b32b62d9ae Cr-Commit-Position: refs/heads/master@{#339193}

Patch Set 1 #

Total comments: 1

Patch Set 2 : git add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/about_memory.css View 2 chunks +22 lines, -8 lines 0 comments Download
M chrome/browser/resources/about_memory.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/about_memory_linux.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/about_memory_mac.html View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options/reset_profile_settings_overlay.css View 1 chunk +6 lines, -2 lines 0 comments Download
D ui/webui/resources/images/help.png View Binary file 0 comments Download
A ui/webui/resources/images/help.svg View 1 chunk +4 lines, -0 lines 0 comments Download
A ui/webui/resources/images/settings.svg View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
5 years, 5 months ago (2015-07-16 21:38:37 UTC) #2
Dan Beam
https://codereview.chromium.org/1228163005/diff/1/ui/webui/resources/webui_resources.grd File ui/webui/resources/webui_resources.grd (left): https://codereview.chromium.org/1228163005/diff/1/ui/webui/resources/webui_resources.grd#oldcode191 ui/webui/resources/webui_resources.grd:191: file="images/help.png" type="BINDATA" /> why are you flattening rather than ...
5 years, 5 months ago (2015-07-16 21:54:14 UTC) #3
Evan Stade
On 2015/07/16 21:54:14, Dan Beam wrote: > https://codereview.chromium.org/1228163005/diff/1/ui/webui/resources/webui_resources.grd > File ui/webui/resources/webui_resources.grd (left): > > https://codereview.chromium.org/1228163005/diff/1/ui/webui/resources/webui_resources.grd#oldcode191 ...
5 years, 5 months ago (2015-07-16 22:24:31 UTC) #4
Dan Beam
lgtm
5 years, 5 months ago (2015-07-16 22:35:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228163005/1
5 years, 5 months ago (2015-07-16 22:43:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/92637) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-16 22:51:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228163005/20001
5 years, 5 months ago (2015-07-16 23:16:08 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-17 01:10:48 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 01:11:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7eb865bd0a9db57cb55617da2c46e3b32b62d9ae
Cr-Commit-Position: refs/heads/master@{#339193}

Powered by Google App Engine
This is Rietveld 408576698