Crankshaft part of the 'loads and stores to global vars through property cell shortcuts' feature.

Crankshaft part of the 'loads and stores to global vars through property cell shortcuts' feature.

BUG=chromium:510738
LOG=N

Committed: https://crrev.com/cc66a1c64ee84bb07db13f017049a0cbebd31a47
Cr-Commit-Position: refs/heads/master@{#29743}

[Igor Sheludko, 2015-07-17 13:27:46]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2015-07-18 20:55:07]

ishell@chromium.org changed reviewers:
+ bmeurer@chromium.org, jkummerow@chromium.org

[Igor Sheludko, 2015-07-18 20:55:08]

Jakob or Benedikt, PTAL and CQ

[Jakob Kummerow, 2015-07-19 10:34:53]

LGTM.

Yay for platform-"specific" code duplication! :-/

https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructio...
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructio...
src/hydrogen-instructions.h:5453: Handle<String>, int, int);
s/Handle<String>/Handle<Name>/ here and below? Since HLoadGlobalGeneric uses
Strings too, it probably doesn't matter much.

[Igor Sheludko, 2015-07-20 08:42:00]

https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructio...
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/1228113008/diff/40001/src/hydrogen-instructio...
src/hydrogen-instructions.h:5453: Handle<String>, int, int);
On 2015/07/19 10:34:53, Jakob wrote:
> s/Handle<String>/Handle<Name>/ here and below? Since HLoadGlobalGeneric uses
> Strings too, it probably doesn't matter much.

This operation is about writing to global via variables, which has only string
names. So it's ok.
Probably I should update name's type in HStoreGlobalViaContext to be
Handle<String> as well.

[Igor Sheludko, 2015-07-20 08:46:39]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2015-07-20 08:46:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1228113008/#ps60001
(title: "Addressed comments + regression test")

[commit-bot: I haz the power, 2015-07-20 08:46:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228113008/60001

[commit-bot: I haz the power, 2015-07-20 08:49:15]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-20 08:49:40]

Patchset 3 (id:??) landed as
https://crrev.com/cc66a1c64ee84bb07db13f017049a0cbebd31a47
Cr-Commit-Position: refs/heads/master@{#29743}