content/common/bluetooth/bluetooth_messages.h - Issue 1228113004: Put the RenderFrame's ID into a per-frame WebBluetooth, and plumb that back to the browser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/bluetooth/bluetooth_messages.h

Issue 1228113004: Put the RenderFrame's ID into a per-frame WebBluetooth, and plumb that back to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@store-request-device-state-in-dispatcher

Patch Set: Remove mention of frames from content/child. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/bluetooth/bluetooth_dispatcher_host.cc ('K') | « content/child/bluetooth/web_bluetooth_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/bluetooth/bluetooth_messages.h

diff --git a/content/common/bluetooth/bluetooth_messages.h b/content/common/bluetooth/bluetooth_messages.h

index 3fce338dd2710a4df29733fcff138e3f0bd4d703..cde3b965bf486d8f89d793474afe1c82d2ccbcc1 100644

--- a/content/common/bluetooth/bluetooth_messages.h

+++ b/content/common/bluetooth/bluetooth_messages.h

@@ -186,15 +186,10 @@ IPC_MESSAGE_CONTROL3(BluetoothMsg_WriteCharacteristicValueError,

// Messages sent from the renderer to the browser.

// Requests a bluetooth device from the browser.

-// TODO(scheib): UI to select and permit access to a device crbug.com/436280.

-// This will include refactoring messages to be associated with an origin

-// and making this initial requestDevice call with an associated frame.

-// This work is deferred to simplify initial prototype patches.

-// The Bluetooth feature, and the BluetoothDispatcherHost are behind

-// the --enable-experimental-web-platform-features flag.

-IPC_MESSAGE_CONTROL4(BluetoothHostMsg_RequestDevice,

+IPC_MESSAGE_CONTROL5(BluetoothHostMsg_RequestDevice,

int /* thread_id */,

int /* request_id */,

+ int /* routing_id */,

scheib 2015/07/16 01:11:46 Yes, adding frame_routing_id here would make this

Jeffrey Yasskin 2015/07/17 01:32:44 Done.

std::vector<content::BluetoothScanFilter>,

std::vector<device::BluetoothUUID> /* optional_services */)