Fix non-standard element handling

Fix non-standard element handling

BUG=

Committed: https://crrev.com/047b4bfbb463a6227a2725faf2e32af5f167a350
Cr-Commit-Position: refs/heads/master@{#29677}

[Toon Verwaest, 2015-07-14 15:45:52]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-07-14 15:45:53]

ptal

[Igor Sheludko, 2015-07-15 10:53:18]

https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1228113003/diff/20001/src/elements.cc#newcode...
src/elements.cc:1655: JSObject::RequireSlowElements(object, arguments);
Why not "if (attributes != NONE)" here?

https://codereview.chromium.org/1228113003/diff/20001/src/lookup.cc
File src/lookup.cc (right):

https://codereview.chromium.org/1228113003/diff/20001/src/lookup.cc#newcode321
src/lookup.cc:321: // TODO(verwaest): Remove this hack once we have a quick way
to check the
This TODO does not belong here anymore. Maybe move it to
JSObject::RequireSlowElements().

https://codereview.chromium.org/1228113003/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1228113003/diff/20001/src/objects.cc#newcode1...
src/objects.cc:14695: GetHeap()->ClearAllICsByKind(Code::KEYED_STORE_IC);
JSObject::RequireSlowElements()?

https://codereview.chromium.org/1228113003/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1228113003/diff/60001/src/objects.cc#newcode4802
src/objects.cc:4802: void JSObject::RequireSlowElements(Handle<JSObject> obj,
It looks like it does not allocate. Why don't you make it an instance method?

[Igor Sheludko, 2015-07-15 11:15:11]

https://codereview.chromium.org/1228113003/diff/60001/test/mjsunit/element-re...
File test/mjsunit/element-read-only.js (right):

https://codereview.chromium.org/1228113003/diff/60001/test/mjsunit/element-re...
test/mjsunit/element-read-only.js:38: var proto = {3: 100};
Maybe use something else than 100 here, just to ensure that the last
assertEquals() sees the reconfigured value.

[Toon Verwaest, 2015-07-15 11:37:17]

Addressed comments, ptal again

[Igor Sheludko, 2015-07-15 11:39:32]

lgtm

https://codereview.chromium.org/1228113003/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1228113003/diff/80001/src/objects.cc#newcode5624
src/objects.cc:5624: Handle<SeededNumberDictionary>
dictionary(object->element_dictionary());
We don't need a handle here.

[Toon Verwaest, 2015-07-15 11:40:49]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-15 11:40:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1228113003/#ps100001
(title: "Remove handle")

[commit-bot: I haz the power, 2015-07-15 11:40:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228113003/100001

[commit-bot: I haz the power, 2015-07-15 12:06:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-15 12:06:45]

Patchset 6 (id:??) landed as
https://crrev.com/047b4bfbb463a6227a2725faf2e32af5f167a350
Cr-Commit-Position: refs/heads/master@{#29677}