Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 12281019: Avoid creating unnecessary branches in Hydrogen (Closed)

Created:
7 years, 10 months ago by Jakob Kummerow
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Avoid creating unnecessary branches in Hydrogen Committed: http://code.google.com/p/v8/source/detail?r=13704

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed Yang's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M src/hydrogen.cc View 1 4 chunks +25 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc#newcode2749 src/hydrogen-instructions.cc:2749: new(zone) HConstant(FACTORY->NewNumber(val, TENURED), \ As discussed offline, there is ...
7 years, 10 months ago (2013-02-19 14:39:07 UTC) #1
Jakob Kummerow
https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc#newcode2749 src/hydrogen-instructions.cc:2749: new(zone) HConstant(FACTORY->NewNumber(val, TENURED), \ On 2013/02/19 14:39:07, Yang wrote: ...
7 years, 10 months ago (2013-02-21 08:46:26 UTC) #2
Yang
On 2013/02/21 08:46:26, Jakob wrote: > https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc > File src/hydrogen-instructions.cc (right): > > https://codereview.chromium.org/12281019/diff/1/src/hydrogen-instructions.cc#newcode2749 > ...
7 years, 10 months ago (2013-02-21 10:04:30 UTC) #3
Jakob Kummerow
7 years, 10 months ago (2013-02-21 11:29:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r13704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698