Updates for dart:js fixes after initial --gen-interop

tools/dom/scripts/systemnative.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the systems to generate
 native binding from the IDL database."""
 
 import emitter
 import os
@@ skipping 365 matching lines @@
     self._interface_type_info = self._type_registry.TypeInfo(self._interface.id)
     self._metadata = options.metadata
     # These get initialized by StartInterface
     self._cpp_header_emitter = None
     self._cpp_impl_emitter = None
     self._members_emitter = None
     self._cpp_declarations_emitter = None
     self._cpp_impl_includes = None
     self._cpp_definitions_emitter = None
     self._cpp_resolver_emitter = None
+    self._dart_js_interop = options.dart_js_interop
 
   def ImplementsMergedMembers(self):
     # We could not add merged functions to implementation class because
     # underlying c++ object doesn't implement them. Merged functions are
     # generated on merged interface implementation instead.
     return False
 
   def CustomJSMembers(self):
     return {}
 
@@ skipping 846 matching lines @@
       if not is_custom:
         self._GenerateOperationNativeCallback(operation, operation.arguments, cpp_callback_name, auto_scope_setup)
     else:
       self._GenerateDispatcher(info, info.operations, dart_declaration, html_name)
 
   def _GenerateDispatcher(self, info, operations, dart_declaration, html_name):
 
     def GenerateCall(
         stmts_emitter, call_emitter, version, operation, argument_count):
       native_suffix = 'Callback'
-      actuals = info.ParametersAsListOfVariables(argument_count, self._type_registry if self._dart_use_blink else None)
+      actuals = info.ParametersAsListOfVariables(argument_count,
+                                                 self._type_registry if self._dart_use_blink else None,

[Alan Knight, 2015/07/16 16:55:52]

Indentation looks very weird here, but it might be just the tool. And it's
Python, so if the indentation is too far wrong the code probably wouldn't work.

[terry, 2015/07/16 17:36:14]

Because of the preceding ( it indents after the (


Here's the Google style guide
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation:

       # Aligned with opening delimiter
       foo = long_function_name(var_one, var_two,
                                var_three, var_four)

+                                                 self._dart_js_interop)
       actuals_s = ", ".join(actuals)
       formals=actuals
       return_type = self.SecureOutputType(operation.type.id)
 
       return_wrap_jso = False
       if self._dart_use_blink:
          return_wrap_jso = self._type_registry.HasInterface(return_type)
 
       native_suffix = 'Callback'
       is_custom = _IsCustom(operation)
@@ skipping 760 matching lines @@
 
 def _IsCustom(op_or_attr):
   assert(isinstance(op_or_attr, IDLMember))
   return 'Custom' in op_or_attr.ext_attrs or 'DartCustom' in op_or_attr.ext_attrs
 
 def _IsCustomValue(op_or_attr, value):
   if _IsCustom(op_or_attr):
     return op_or_attr.ext_attrs.get('Custom') == value \
            or op_or_attr.ext_attrs.get('DartCustom') == value
   return False