Issue 1228083003: Stop leaking temp directories in SkyShell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228083003: Stop leaking temp directories in SkyShell (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Stop leaking temp directories in SkyShell At startup, we make a list of all the temp directories that already exist and then nuke them on a background thread after a five second delay. The five second delay isn't particularly satisfying, but I think it's wortwhile to get this work off the critical path of startup. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8b97ed9896bf3e2c2e8dd820a19fe6183d418d94

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -1 line)			Patch
M	sky/shell/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/shell/android/org/domokit/sky/shell/ResourceCleaner.java	View	1 chunk	+86 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyApplication.java	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 5 months ago (2015-07-09 16:57:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8b97ed9896bf3e2c2e8dd820a19fe6183d418d94 (presubmit successful).