Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1228063004: Fix keyed element access wrt string wrappers (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix keyed element access wrt string wrappers BUG=v8:4296 LOG=n Committed: https://crrev.com/01f40e6ad6c8137708955494987857fbe489616b Cr-Commit-Position: refs/heads/master@{#29618}

Patch Set 1 #

Patch Set 2 : Ports #

Patch Set 3 : typo #

Total comments: 8

Patch Set 4 : Use CompareRoot #

Patch Set 5 : #

Patch Set 6 : Addressed comments #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -29 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 1 chunk +15 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 3 4 5 1 chunk +11 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 2 3 4 5 2 chunks +8 lines, -6 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 3 4 5 6 1 chunk +5 lines, -2 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 3 4 5 1 chunk +5 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 3 4 5 1 chunk +10 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-4296.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-13 14:06:53 UTC) #2
Jakob Kummerow
STATIC_ASSERT comments apply to all architectures. https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc#newcode3800 src/arm/macro-assembler-arm.cc:3800: cmp(current, Operand(factory->null_value())); why ...
5 years, 5 months ago (2015-07-13 15:00:58 UTC) #3
Jakob Kummerow
LGTM https://codereview.chromium.org/1228063004/diff/90001/src/ic/mips/ic-mips.cc File src/ic/mips/ic-mips.cc (right): https://codereview.chromium.org/1228063004/diff/90001/src/ic/mips/ic-mips.cc#newcode663 src/ic/mips/ic-mips.cc:663: __ Branch(&slow, lt, t0, Operand(JS_OBJECT_TYPE)); forgot an "lo" ...
5 years, 5 months ago (2015-07-13 15:12:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1228063004/110001
5 years, 5 months ago (2015-07-13 15:13:18 UTC) #7
commit-bot: I haz the power
Committed patchset #7 (id:110001)
5 years, 5 months ago (2015-07-13 15:39:02 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:39:18 UTC) #9
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/01f40e6ad6c8137708955494987857fbe489616b
Cr-Commit-Position: refs/heads/master@{#29618}

Powered by Google App Engine
This is Rietveld 408576698