Fix keyed element access wrt string wrappers

Fix keyed element access wrt string wrappers

BUG=v8:4296
LOG=n

Committed: https://crrev.com/01f40e6ad6c8137708955494987857fbe489616b
Cr-Commit-Position: refs/heads/master@{#29618}

[Toon Verwaest, 2015-07-13 14:06:53]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-07-13 14:06:53]

ptal

[Jakob Kummerow, 2015-07-13 15:00:58]

STATIC_ASSERT comments apply to all architectures.

https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm...
src/arm/macro-assembler-arm.cc:3800: cmp(current,
Operand(factory->null_value()));
why not CompareRoot()?

https://codereview.chromium.org/1228063004/diff/2/src/arm/macro-assembler-arm...
src/arm/macro-assembler-arm.cc:3810: cmp(r4, Operand(JS_OBJECT_TYPE));
s/r4/scratch1/

Why don't tests catch this?

https://codereview.chromium.org/1228063004/diff/2/src/ia32/macro-assembler-ia...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/ia32/macro-assembler-ia...
src/ia32/macro-assembler-ia32.cc:3193: DCHECK(JS_PROXY_TYPE < JS_OBJECT_TYPE);
nit: STATIC_ASSERT

https://codereview.chromium.org/1228063004/diff/2/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/ic/arm/ic-arm.cc#newcod...
src/ic/arm/ic-arm.cc:666: __ b(lt, &slow);
s/lt/lo/ for unsigned comparison

https://codereview.chromium.org/1228063004/diff/2/src/ic/arm64/ic-arm64.cc
File src/ic/arm64/ic-arm64.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/ic/arm64/ic-arm64.cc#ne...
src/ic/arm64/ic-arm64.cc:665: __ B(lt, &slow);
s/lt/lo/ for unsigned comparison

https://codereview.chromium.org/1228063004/diff/2/src/ic/ia32/ic-ia32.cc
File src/ic/ia32/ic-ia32.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/ic/ia32/ic-ia32.cc#newc...
src/ic/ia32/ic-ia32.cc:544: DCHECK(JS_VALUE_TYPE < JS_OBJECT_TYPE);
STATIC_ASSERT

https://codereview.chromium.org/1228063004/diff/2/src/ic/mips/ic-mips.cc
File src/ic/mips/ic-mips.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/ic/mips/ic-mips.cc#newc...
src/ic/mips/ic-mips.cc:663: __ Branch(&slow, lt, t0, Operand(JS_OBJECT_TYPE));
s/lt/lo/ for unsigned comparison

https://codereview.chromium.org/1228063004/diff/2/src/mips/macro-assembler-mi...
File src/mips/macro-assembler-mips.cc (right):

https://codereview.chromium.org/1228063004/diff/2/src/mips/macro-assembler-mi...
src/mips/macro-assembler-mips.cc:6002: Branch(found, lt, scratch1,
Operand(JS_OBJECT_TYPE));
s/lt/lo/ for unsigned comparison

[Jakob Kummerow, 2015-07-13 15:12:03]

LGTM

https://codereview.chromium.org/1228063004/diff/90001/src/ic/mips/ic-mips.cc
File src/ic/mips/ic-mips.cc (right):

https://codereview.chromium.org/1228063004/diff/90001/src/ic/mips/ic-mips.cc#...
src/ic/mips/ic-mips.cc:663: __ Branch(&slow, lt, t0, Operand(JS_OBJECT_TYPE));
forgot an "lo" here :-)

[Toon Verwaest, 2015-07-13 15:13:02]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-07-13 15:13:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1228063004/#ps110001
(title: " ")

[commit-bot: I haz the power, 2015-07-13 15:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1228063004/110001

[commit-bot: I haz the power, 2015-07-13 15:39:02]

Committed patchset #7 (id:110001)

[commit-bot: I haz the power, 2015-07-13 15:39:18]

Patchset 7 (id:??) landed as
https://crrev.com/01f40e6ad6c8137708955494987857fbe489616b
Cr-Commit-Position: refs/heads/master@{#29618}