Web MIDI: allow to show an infobar for permission requests from local files

Web MIDI: allow to show an infobar for permission requests from local files

BUG=331223
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243814

[Takashi Toyoshima, 2014-01-02 08:58:50]

PTAL

[Takashi Toyoshima, 2014-01-08 09:24:54]

+scherkus

[markusheintz_, 2014-01-08 09:32:29]

LGTM after adding a FIXME: comment

This is due to a bug in GURL. If I remember the bug correctly for file URLs the
origin() method of GURL returns an invalid GURL.

There is a similar problem with geolocation.

[Takashi Toyoshima, 2014-01-08 10:31:14]

To my understanding this comes from Cross-Origin Resource Sharing spec;
http://www.w3.org/TR/cors/.
From 7.1.7 Generic Cross-Origin Request Algorithms, step 6 says;

If the request URL origin is not same origin with the original URL origin, set
source origin to a globally unique identifier (becomes "null" when transmitted).

For security reason, Chrome handles all files having different origin each
other. So basically all requests from file scheme URL has null origin. This is
the reason why |requesting_url| can be invalid and empty when the request comes
from files. Origin handling code is implemented in blink by Adam Barth, IIRC,
and widely used for Web APIs.

So, I think fixing it in chromium is not workaround, and FIXME is not needed.
WDYT?

[scherkus (not reviewing), 2014-01-09 00:27:20]

lgtm

[Takashi Toyoshima, 2014-01-09 02:28:51]

Markus: I'll submit this for now, but keep the bug open to discuss similar issue
for other APIs.

[commit-bot: I haz the power, 2014-01-09 02:32:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/122803002/1

[commit-bot: I haz the power, 2014-01-09 08:07:35]

Change committed as 243814

[markusheintz_, 2014-01-09 15:36:44]

On 2014/01/09 02:28:51, Takashi Toyoshima (chromium) wrote:
> Markus: I'll submit this for now, but keep the bug open to discuss similar
issue
> for other APIs.

Thanks a lot for digging this up in the SPEC. What you did SGTM and LGTM :)