Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: chrome/browser/prefs/tracked/interceptable_pref_filter.cc

Issue 1227973003: Componentize //chrome/browser/prefs/tracked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/interceptable_pref_filter.cc
diff --git a/chrome/browser/prefs/tracked/interceptable_pref_filter.cc b/chrome/browser/prefs/tracked/interceptable_pref_filter.cc
deleted file mode 100644
index adc61163296ccc7ba2a75146cf7708955e971148..0000000000000000000000000000000000000000
--- a/chrome/browser/prefs/tracked/interceptable_pref_filter.cc
+++ /dev/null
@@ -1,39 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/prefs/tracked/interceptable_pref_filter.h"
-
-#include "base/bind.h"
-
-InterceptablePrefFilter::InterceptablePrefFilter() {}
-InterceptablePrefFilter::~InterceptablePrefFilter() {}
-
-void InterceptablePrefFilter::FilterOnLoad(
- const PostFilterOnLoadCallback& post_filter_on_load_callback,
- scoped_ptr<base::DictionaryValue> pref_store_contents) {
- if (filter_on_load_interceptor_.is_null()) {
- FinalizeFilterOnLoad(post_filter_on_load_callback,
- pref_store_contents.Pass(),
- false);
- } else {
- // Note, in practice (in the implementation as it was in May 2014) it would
- // be okay to pass an unretained |this| pointer below, but in order to avoid
- // having to augment the API everywhere to explicitly enforce the ownership
- // model as it happens to currently be: make the relationship simpler by
- // weakly binding the FinalizeFilterOnLoadCallback below to |this|.
- const FinalizeFilterOnLoadCallback finalize_filter_on_load(
- base::Bind(&InterceptablePrefFilter::FinalizeFilterOnLoad,
- AsWeakPtr(),
- post_filter_on_load_callback));
- filter_on_load_interceptor_.Run(finalize_filter_on_load,
- pref_store_contents.Pass());
- filter_on_load_interceptor_.Reset();
- }
-}
-
-void InterceptablePrefFilter::InterceptNextFilterOnLoad(
- const FilterOnLoadInterceptor& filter_on_load_interceptor) {
- DCHECK(filter_on_load_interceptor_.is_null());
- filter_on_load_interceptor_ = filter_on_load_interceptor;
-}
« no previous file with comments | « chrome/browser/prefs/tracked/interceptable_pref_filter.h ('k') | chrome/browser/prefs/tracked/mock_validation_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698