Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: components/prefs_tracker/tracked_preference_helper.cc

Issue 1227973003: Componentize //chrome/browser/prefs/tracked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: modified folder to prefs_tracker Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/prefs_tracker/tracked_preference_helper.cc
diff --git a/chrome/browser/prefs/tracked/tracked_preference_helper.cc b/components/prefs_tracker/tracked_preference_helper.cc
similarity index 92%
rename from chrome/browser/prefs/tracked/tracked_preference_helper.cc
rename to components/prefs_tracker/tracked_preference_helper.cc
index b3b528e56063e67d8614d26605903263afc3d842..e7b61df1f2f4787a6c2eaa92b7f187ebe7e98763 100644
--- a/chrome/browser/prefs/tracked/tracked_preference_helper.cc
+++ b/components/prefs_tracker/tracked_preference_helper.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/prefs/tracked/tracked_preference_helper.h"
+#include "components/prefs_tracker/tracked_preference_helper.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
@@ -107,12 +107,9 @@ void TrackedPreferenceHelper::ReportSplitPreferenceChangedCount(
// The histogram below is an expansion of the UMA_HISTOGRAM_COUNTS_100 macro
// adapted to allow for a dynamically suffixed histogram name.
// Note: The factory creates and owns the histogram.
- base::HistogramBase* histogram =
- base::LinearHistogram::FactoryGet(
gab 2015/07/23 21:41:16 This was easier to read IMO and is how it's writte
Jitu( very slow this week) 2015/07/24 09:09:23 Done. As i used git format cl command this piece
- "Settings.TrackedSplitPreferenceChanged." + pref_path_,
- 1,
- 100, // Allow counts up to 100.
- 101,
- base::HistogramBase::kUmaTargetedHistogramFlag);
+ base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
+ "Settings.TrackedSplitPreferenceChanged." + pref_path_, 1,
+ 100, // Allow counts up to 100.
+ 101, base::HistogramBase::kUmaTargetedHistogramFlag);
histogram->Add(count);
}

Powered by Google App Engine
This is Rietveld 408576698