components/user_prefs/tracked/pref_names.h - Issue 1227973003: Componentize //chrome/browser/prefs/tracked.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/user_prefs/tracked/pref_names.h

Issue 1227973003: Componentize //chrome/browser/prefs/tracked. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/user_prefs/BUILD.gn ('K') | « components/user_prefs/tracked/pref_hash_store_transaction.h ('k') | components/user_prefs/tracked/pref_names.cc » ('j') | components/user_prefs/tracked/tracked_preference_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_

	6 #define COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_

	7

	8 namespace user_prefs_prefs {
	gab 2015/07/29 18:12:14 user_prefs_prefs sounds very weird to me... can yo user_prefs_prefs sounds very weird to me... can you think of something better? Jitu( very slow this week) 2015/07/30 08:06:13 How about -- prefs ( simple) -- user_prefs -- use Show quoted text On 2015/07/29 18:12:14, gab wrote: > user_prefs_prefs sounds very weird to me... can you think of something better? How about -- prefs ( simple) -- user_prefs -- user_prefs_tracked gab 2015/07/30 15:38:33 Looking at the trend @ [1], looks like either just Show quoted text On 2015/07/30 08:06:13, jitu wrote: > On 2015/07/29 18:12:14, gab wrote: > > user_prefs_prefs sounds very weird to me... can you think of something better? > > How about > -- prefs ( simple) > -- user_prefs > -- user_prefs_tracked Looking at the trend @ [1], looks like either just use "prefs" or a "prefs" subnamespace inside the component's namespace, e.g. user_prefs::prefs::. I think I prefer the former, simpler form. [1] https://code.google.com/p/chromium/codesearch#search/&q=components/.pref_nam... Jitu( very slow this week)* 2015/08/03 07:55:13 Done. Show quoted text On 2015/07/30 15:38:33, gab wrote: > On 2015/07/30 08:06:13, jitu wrote: > > On 2015/07/29 18:12:14, gab wrote: > > > user_prefs_prefs sounds very weird to me... can you think of something > better? > > > > How about > > -- prefs ( simple) > > -- user_prefs > > -- user_prefs_tracked > > Looking at the trend @ [1], looks like either just use "prefs" or a "prefs" > subnamespace inside the component's namespace, e.g. user_prefs::prefs::. > > I think I prefer the former, simpler form. > > [1] > https://code.google.com/p/chromium/codesearch#search/&q=components/.*pref_nam... Done.
	9

	10 extern const char kPreferenceResetTime[];

	11

	12 } // namespace prefs

	13

	14 #endif // COMPONENTS_USER_PREFS_TRACKED_PREF_NAMES_H_

OLD	NEW