Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1227963005: [turbofan] Context specialization should only specialize loads/stores. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Context specialization should only specialize loads/stores. The JSContextSpecialization should only care about loads from the context and stores to the context, where the context is either a HeapConstant or the special context Parameter (and a context for the outer most function is provided). This way we don't eagerly embed arbitrary context constants for no benefit, but we still specialize the loads and store which we actually care about. R=mstarzinger@chromium.org Committed: https://crrev.com/443b071abe7e8480cb76c7a00346bc553dec5d5c Cr-Commit-Position: refs/heads/master@{#29602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M src/compiler/js-context-specialization.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/js-context-specialization.cc View 3 chunks +31 lines, -31 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-13 11:18:07 UTC) #1
Benedikt Meurer
Michi: PTAL Danno: FYI As discussed offline.
5 years, 5 months ago (2015-07-13 11:18:35 UTC) #3
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-13 12:24:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227963005/1
5 years, 5 months ago (2015-07-13 12:28:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 12:30:55 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 12:31:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/443b071abe7e8480cb76c7a00346bc553dec5d5c
Cr-Commit-Position: refs/heads/master@{#29602}

Powered by Google App Engine
This is Rietveld 408576698