Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: sky/sdk/lib/widgets/block_viewport.dart

Issue 1227963003: Card "swipe-away" dismiss version 3: Uses BlockViewport (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/widgets/block_viewport.dart
diff --git a/sky/sdk/lib/widgets/block_viewport.dart b/sky/sdk/lib/widgets/block_viewport.dart
index e53240ae823b3fcd54ee5911301fff1814014299..8aa0f0c3756dd5379739ca19977e2cf0cc7417af 100644
--- a/sky/sdk/lib/widgets/block_viewport.dart
+++ b/sky/sdk/lib/widgets/block_viewport.dart
@@ -100,7 +100,7 @@ class BlockViewport extends RenderObjectWrapper {
return right;
}
- bool _dirty = false;
+ bool _dirty = true;
eseidel 2015/07/10 00:06:00 Did you mean to change this?
hansmuller 2015/07/10 00:07:58 Yes, that's the way it's supposed to be.
bool retainStatefulNodeIfPossible(BlockViewport newNode) {
retainStatefulRenderObjectWrapper(newNode);
@@ -126,7 +126,7 @@ class BlockViewport extends RenderObjectWrapper {
assert(_currentStartIndex >= 0);
assert(builder != null);
assert(root != null);
- int lastIndex = _currentStartIndex + _currentChildCount;
+ int lastIndex = _currentStartIndex + _currentChildCount - 1;
for (int index = _currentStartIndex; index <= lastIndex; index += 1) {
Widget widget = builder(index);
assert(widget != null);
« sky/sdk/example/widgets/card_collection.dart ('K') | « sky/sdk/example/widgets/card_collection.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698