chromecast/crash/linux/synchronized_minidump_manager.cc - Issue 1227963002: Replace system IO calls in chromecast/crash with Chrome utilities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/crash/linux/synchronized_minidump_manager.cc

Issue 1227963002: Replace system IO calls in chromecast/crash with Chrome utilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Address smaller issues. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/crash/linux/synchronized_minidump_manager.cc

diff --git a/chromecast/crash/linux/synchronized_minidump_manager.cc b/chromecast/crash/linux/synchronized_minidump_manager.cc

index 358427a2dd31a3532e82a9d6703bd78f00f161e2..3a606c345932ae61ba733160e969ae5fb67051bc 100644

--- a/chromecast/crash/linux/synchronized_minidump_manager.cc

+++ b/chromecast/crash/linux/synchronized_minidump_manager.cc

@@ -156,8 +156,7 @@ int SynchronizedMinidumpManager::ParseLockFile() {

if (info->valid() && info->crashed_process_dump().size() > 0) {

dumps->push_back(info.Pass());

} else {

- LOG(WARNING) << "Entry is not valid: " << entry;

- return -1;

+ LOG(WARNING) << "Ignoring invalid entry: " << entry;

wzhong 2015/07/16 22:46:44 Remove {} for simple if else statement.

slan 2015/07/16 22:57:31 Done.

}

« no previous file with comments | « chromecast/crash/linux/minidump_generator.h ('k') | no next file » | no next file with comments »