Allow browser tests to use a MockCertVerifier

net/cert/cert_verify_result.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_CERT_VERIFY_RESULT_H_
 #define NET_CERT_CERT_VERIFY_RESULT_H_
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "net/base/net_export.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/cert/x509_cert_types.h"
+#include "net/cert/x509_certificate.h"

[estark, 2015/07/09 17:27:21]

I can't for the life of me figure out why this is needed. :( Without it,
CertVerifierBrowserTests fail to compile:

In file included from ../../chrome/test/base/cert_verifier_browser_test.cc:5:
In file included from ../../chrome/test/base/cert_verifier_browser_test.h:8:
In file included from ../../chrome/test/base/in_process_browser_test.h:10:
../../base/memory/ref_counted.h:398:6: error: member access into incomplete type
'net::X509Certificate'
  ptr->AddRef();
     ^
../../base/memory/ref_counted.h:316:7: note: in instantiation of member function
'scoped_refptr<net::X509Certificate>::AddRef' requested here
      AddRef(p);
      ^
../../base/memory/ref_counted.h:325:18: note: in instantiation of member
function 'scoped_refptr<net::X509Certificate>::operator=' requested here
    return *this = r.ptr_;
                 ^
../../net/cert/cert_verify_result.h:20:18: note: in instantiation of member
function 'scoped_refptr<net::X509Certificate>::operator=' requested here
class NET_EXPORT CertVerifyResult {
                 ^
../../net/cert/cert_verifier.h:20:7: note: forward declaration of
'net::X509Certificate'
class X509Certificate;

[Ryan Sleevi, 2015/07/09 19:40:26]

Because you're invoking a compiler-default copy-ctor, which triggers
AddRef/Release on line 37, which needs to be a complete type.

Was this error when you had additional code / tests using the CFBT? I'd expect
it when you return the CertVerifyResult in a .cc that hadn't included the
x509_certificate.h

 
 namespace net {
 
-class X509Certificate;
-
 // The result of certificate verification.
 class NET_EXPORT CertVerifyResult {
  public:
   CertVerifyResult();
   ~CertVerifyResult();
 
   void Reset();
 
   // Copies from |other| to |this|.
   void CopyFrom(const CertVerifyResult& other) {
@@ skipping 36 matching lines @@
   bool is_issued_by_additional_trust_anchor;
 
   // True if a fallback to the common name was used when matching the host
   // name, rather than using the subjectAltName.
   bool common_name_fallback_used;
 };
 
 }  // namespace net
 
 #endif  // NET_CERT_CERT_VERIFY_RESULT_H_