Issue 122793002: Move GeolocationClientMock.h out of platform/ into web/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122793002: Move GeolocationClientMock.h out of platform/ into web/ (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
Stephen Chennney, eseidel, abarth-chromium

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Move GeolocationClientMock.h out of platform/ into web/ Since only WebGeolocationClientMock uses this file, move it to web/ and into blink namespace. BUG=297477 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164403

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -313 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/core/platform/mock/GeolocationClientMock.h	View	1 chunk	+0 lines, -99 lines	0 comments	Download
D	Source/core/platform/mock/GeolocationClientMock.cpp	View	1 chunk	+0 lines, -190 lines	0 comments	Download
A +	Source/web/GeolocationClientMock.h	View	3 chunks	+16 lines, -15 lines	0 comments	Download
A +	Source/web/GeolocationClientMock.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	Source/web/WebGeolocationClientMock.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	public/web/WebGeolocationClientMock.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download

Total messages: 4 (0 generated)

rwlbuis

This class would be hard to move to Source/platform as it relies on modules/, I ...

6 years, 11 months ago (2013-12-31 18:01:43 UTC) #1

abarth-chromium

LGTM This file doesn't really belong in web either, but I understand that it's one ...

6 years, 11 months ago (2013-12-31 18:47:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/122793002/1

6 years, 11 months ago (2013-12-31 18:59:30 UTC) #3

Message was sent while issue was closed.

Change committed as 164403