Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1227923003: X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. port 4b38c15817033ccd9a65efbb3d038ae2423293c2 (r29527). original commit message: We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. BUG= Committed: https://crrev.com/a02e644c50289e4a141799a4a612a3374eeb26ad Cr-Commit-Position: refs/heads/master@{#29629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-14 01:51:36 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 02:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227923003/1
5 years, 5 months ago (2015-07-14 02:02:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 02:29:50 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:30:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a02e644c50289e4a141799a4a612a3374eeb26ad
Cr-Commit-Position: refs/heads/master@{#29629}

Powered by Google App Engine
This is Rietveld 408576698