src/pdf/SkPDFStream.cpp - Issue 1227913008: SkPDF: Memory improvements for PDF Streams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFStream.cpp

Issue 1227913008: SkPDF: Memory improvements for PDF Streams (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2015-08-19 (Wednesday) 17:47:45 EDT Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFStream.cpp

diff --git a/src/pdf/SkPDFStream.cpp b/src/pdf/SkPDFStream.cpp

index 69ce317bb9ccd50aafa8d1c5f149e8dd8decc795..b8f2e4e92b896d656e9a63d50ae7e8574f99ea1f 100644

--- a/src/pdf/SkPDFStream.cpp

+++ b/src/pdf/SkPDFStream.cpp

@@ -20,7 +20,7 @@ void SkPDFStream::emitObject(SkWStream* stream,

const SkPDFSubstituteMap& substitutes) const {

SkASSERT(fCompressedData);

this->INHERITED::emitObject(stream, objNumMap, substitutes);

- // Note: emitObject isn't marked const, but could be in the future

+ // duplicate (a cheap operation) preserves const on fCompressedData.

SkAutoTDelete<SkStreamRewindable> dup(fCompressedData->duplicate());

SkASSERT(dup);

SkASSERT(dup->hasLength());

« no previous file with comments | « src/pdf/SkPDFFont.cpp ('k') | src/pdf/SkPDFTypes.h » ('j') | no next file with comments »