Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1227913006: Don't use length property when bounds checking atomics functions (Closed)

Created:
5 years, 5 months ago by binji
Modified:
5 years, 5 months ago
Reviewers:
Jarin, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't use length property when bounds checking atomics functions The length property can be monkey-patched, so use the native function instead. R=jarin@chromium.org BUG= Committed: https://crrev.com/a55fcc93ae8614095644007bba713a64048a864c Cr-Commit-Position: refs/heads/master@{#29653}

Patch Set 1 #

Patch Set 2 : modify regression test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M src/harmony-atomics.js View 9 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-501809.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
binji
5 years, 5 months ago (2015-07-10 18:12:57 UTC) #1
adamk
lgtm
5 years, 5 months ago (2015-07-10 18:47:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227913006/20001
5 years, 5 months ago (2015-07-14 15:46:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-14 16:17:16 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 16:17:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a55fcc93ae8614095644007bba713a64048a864c
Cr-Commit-Position: refs/heads/master@{#29653}

Powered by Google App Engine
This is Rietveld 408576698