Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227903003: Revert of reland #1: Set mac_min_sdk=10.10 on chromium.mac bots (Closed)

Created:
5 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 5 months ago
Reviewers:
erikchen, smut, smut
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of reland #1: Set mac_min_sdk=10.10 on chromium.mac bots (patchset #2 id:20001 of https://codereview.chromium.org/1212443005/) Reason for revert: Looks like this broke some tests on Mac bots, see http://crbug.com/508389 Original issue's description: > reland #1: Set mac_min_sdk=10.10 on chromium.mac bots > > Original author: smut@ > > >BUG=463170 > > > >Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295942 > > > >patch from issue 1201213003 at patchset 20001 (http://crrev.com/1201213003#ps20001) > > BUG=463170 > TBR=phajdan.jr@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295949 TBR=smut@google.com,smut@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_mac.py View 2 chunks +0 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder_Trybot.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_6_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng_analyze.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gpu_tests.json View 3 chunks +3 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_results.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_no_summary.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_swarming_error.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/telemetry_gpu_with_results_but_bad_exit_code.json View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/gpu/build_and_upload.expected/mac_fyi_link_against_10_10.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of reland #1: Set mac_min_sdk=10.10 on chromium.mac bots
5 years, 5 months ago (2015-07-09 10:10:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227903003/1
5 years, 5 months ago (2015-07-09 10:10:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295961
5 years, 5 months ago (2015-07-09 10:10:52 UTC) #3
smut
5 years, 5 months ago (2015-07-09 19:59:40 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698