content/renderer/external_popup_menu_browsertest.cc - Issue 12279015: Mac Chromium style checker cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/external_popup_menu_browsertest.cc

Issue 12279015: Mac Chromium style checker cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/external_popup_menu_browsertest.cc

diff --git a/content/renderer/external_popup_menu_browsertest.cc b/content/renderer/external_popup_menu_browsertest.cc

index c271e09c820b936f8360644a556a7b94344fea0e..56810d9330a4f6474fa8d1ac855a35c076b76b51 100644

--- a/content/renderer/external_popup_menu_browsertest.cc

+++ b/content/renderer/external_popup_menu_browsertest.cc

@@ -128,7 +128,7 @@ class ExternalPopupMenuRemoveTest : public ExternalPopupMenuTest {

ExternalPopupMenuRemoveTest() {}

protected:

- virtual bool ShouldRemoveSelectOnChange() const { return true; }

+ virtual bool ShouldRemoveSelectOnChange() const OVERRIDE { return true; }

};

// Tests that nothing bad happen when the page removes the select when it