| Index: src/arm64/full-codegen-arm64.cc
|
| diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc
|
| index 324bfb8160158e3de1875abbd8da9ffb6d89c41c..60cd9e70c7e1ebadae002d899cd61caae2dd6f68 100644
|
| --- a/src/arm64/full-codegen-arm64.cc
|
| +++ b/src/arm64/full-codegen-arm64.cc
|
| @@ -1357,7 +1357,7 @@ void FullCodeGenerator::EmitSetHomeObjectIfNeeded(Expression* initializer,
|
|
|
|
|
| void FullCodeGenerator::EmitLoadGlobalCheckExtensions(VariableProxy* proxy,
|
| - TypeofState typeof_state,
|
| + TypeofMode typeof_mode,
|
| Label* slow) {
|
| Register current = cp;
|
| Register next = x10;
|
| @@ -1401,7 +1401,7 @@ void FullCodeGenerator::EmitLoadGlobalCheckExtensions(VariableProxy* proxy,
|
|
|
| // All extension objects were empty and it is safe to use a normal global
|
| // load machinery.
|
| - EmitGlobalVariableLoad(proxy, typeof_state);
|
| + EmitGlobalVariableLoad(proxy, typeof_mode);
|
| }
|
|
|
|
|
| @@ -1436,9 +1436,8 @@ MemOperand FullCodeGenerator::ContextSlotOperandCheckExtensions(Variable* var,
|
|
|
|
|
| void FullCodeGenerator::EmitDynamicLookupFastCase(VariableProxy* proxy,
|
| - TypeofState typeof_state,
|
| - Label* slow,
|
| - Label* done) {
|
| + TypeofMode typeof_mode,
|
| + Label* slow, Label* done) {
|
| // Generate fast-case code for variables that might be shadowed by
|
| // eval-introduced variables. Eval is used a lot without
|
| // introducing variables. In those cases, we do not want to
|
| @@ -1446,7 +1445,7 @@ void FullCodeGenerator::EmitDynamicLookupFastCase(VariableProxy* proxy,
|
| // containing the eval.
|
| Variable* var = proxy->var();
|
| if (var->mode() == DYNAMIC_GLOBAL) {
|
| - EmitLoadGlobalCheckExtensions(proxy, typeof_state, slow);
|
| + EmitLoadGlobalCheckExtensions(proxy, typeof_mode, slow);
|
| __ B(done);
|
| } else if (var->mode() == DYNAMIC_LOCAL) {
|
| Variable* local = var->local_if_not_shadowed();
|
| @@ -1468,7 +1467,7 @@ void FullCodeGenerator::EmitDynamicLookupFastCase(VariableProxy* proxy,
|
|
|
|
|
| void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
|
| - TypeofState typeof_state) {
|
| + TypeofMode typeof_mode) {
|
| Variable* var = proxy->var();
|
| DCHECK(var->IsUnallocatedOrGlobalSlot() ||
|
| (var->IsLookupSlot() && var->mode() == DYNAMIC_GLOBAL));
|
| @@ -1476,14 +1475,12 @@ void FullCodeGenerator::EmitGlobalVariableLoad(VariableProxy* proxy,
|
| __ Mov(LoadDescriptor::NameRegister(), Operand(var->name()));
|
| __ Mov(LoadDescriptor::SlotRegister(),
|
| SmiFromSlot(proxy->VariableFeedbackSlot()));
|
| - // Inside typeof use a regular load, not a contextual load, to avoid
|
| - // a reference error.
|
| - CallLoadIC(typeof_state == NOT_INSIDE_TYPEOF ? CONTEXTUAL : NOT_CONTEXTUAL);
|
| + CallLoadIC(typeof_mode);
|
| }
|
|
|
|
|
| void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
|
| - TypeofState typeof_state) {
|
| + TypeofMode typeof_mode) {
|
| // Record position before possible IC call.
|
| SetExpressionPosition(proxy);
|
| PrepareForBailoutForId(proxy->BeforeId(), NO_REGISTERS);
|
| @@ -1495,7 +1492,7 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
|
| case VariableLocation::GLOBAL:
|
| case VariableLocation::UNALLOCATED: {
|
| Comment cmnt(masm_, "Global variable");
|
| - EmitGlobalVariableLoad(proxy, typeof_state);
|
| + EmitGlobalVariableLoad(proxy, typeof_mode);
|
| context()->Plug(x0);
|
| break;
|
| }
|
| @@ -1503,7 +1500,7 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
|
| case VariableLocation::PARAMETER:
|
| case VariableLocation::LOCAL:
|
| case VariableLocation::CONTEXT: {
|
| - DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_state);
|
| + DCHECK_EQ(NOT_INSIDE_TYPEOF, typeof_mode);
|
| Comment cmnt(masm_, var->IsContextSlot()
|
| ? "Context variable"
|
| : "Stack variable");
|
| @@ -1577,13 +1574,13 @@ void FullCodeGenerator::EmitVariableLoad(VariableProxy* proxy,
|
| Label done, slow;
|
| // Generate code for loading from variables potentially shadowed by
|
| // eval-introduced variables.
|
| - EmitDynamicLookupFastCase(proxy, typeof_state, &slow, &done);
|
| + EmitDynamicLookupFastCase(proxy, typeof_mode, &slow, &done);
|
| __ Bind(&slow);
|
| Comment cmnt(masm_, "Lookup variable");
|
| __ Mov(x1, Operand(var->name()));
|
| __ Push(cp, x1); // Context and name.
|
| Runtime::FunctionId function_id =
|
| - typeof_state == NOT_INSIDE_TYPEOF
|
| + typeof_mode == NOT_INSIDE_TYPEOF
|
| ? Runtime::kLoadLookupSlot
|
| : Runtime::kLoadLookupSlotNoReferenceError;
|
| __ CallRuntime(function_id, 2);
|
| @@ -2120,7 +2117,7 @@ void FullCodeGenerator::EmitNamedPropertyLoad(Property* prop) {
|
| __ Mov(LoadDescriptor::NameRegister(), Operand(key->value()));
|
| __ Mov(LoadDescriptor::SlotRegister(),
|
| SmiFromSlot(prop->PropertyFeedbackSlot()));
|
| - CallLoadIC(NOT_CONTEXTUAL, language_mode());
|
| + CallLoadIC(INSIDE_TYPEOF, language_mode());
|
| }
|
|
|
|
|
| @@ -4416,7 +4413,7 @@ void FullCodeGenerator::EmitLoadJSRuntimeFunction(CallRuntime* expr) {
|
| __ Mov(LoadDescriptor::NameRegister(), Operand(name));
|
| __ Mov(LoadDescriptor::SlotRegister(),
|
| SmiFromSlot(expr->CallRuntimeFeedbackSlot()));
|
| - CallLoadIC(NOT_CONTEXTUAL);
|
| + CallLoadIC(INSIDE_TYPEOF);
|
| }
|
|
|
|
|
| @@ -5200,7 +5197,7 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
| __ LoadRoot(load_name, Heap::kdone_stringRootIndex); // "done"
|
| __ Mov(LoadDescriptor::SlotRegister(),
|
| SmiFromSlot(expr->DoneFeedbackSlot()));
|
| - CallLoadIC(NOT_CONTEXTUAL); // x0=result.done
|
| + CallLoadIC(INSIDE_TYPEOF); // x0=result.done
|
| // The ToBooleanStub argument (result.done) is in x0.
|
| Handle<Code> bool_ic = ToBooleanStub::GetUninitialized(isolate());
|
| CallIC(bool_ic);
|
| @@ -5211,7 +5208,7 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
|
| __ LoadRoot(load_name, Heap::kvalue_stringRootIndex); // "value"
|
| __ Mov(LoadDescriptor::SlotRegister(),
|
| SmiFromSlot(expr->ValueFeedbackSlot()));
|
| - CallLoadIC(NOT_CONTEXTUAL); // x0=result.value
|
| + CallLoadIC(INSIDE_TYPEOF); // x0=result.value
|
| context()->DropAndPlug(2, x0); // drop iter and g
|
| break;
|
| }
|
|
|