DescriptionRevert of Add support for escaped target names in isolate driver (4th try) (patchset #2 id:20001 of https://codereview.chromium.org/1221333013/)
Reason for revert:
Speculative revert: appreas to have broken the GPU mac builders.
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141
Original issue's description:
> Add support for escaped target names in isolate driver (4th try)
>
> Currently the isolate_driver.py which creates the dependency files
> used by the isolate system, does a simple split on all spaces when
> trying to identify targets.
>
> This can fail if the target name contains a space in the name. In
> ninja, spaces are escaped with a $-prefix. An example would be
> 'Content$ Shell$ Helper.app'.
>
> This CL adds support for such target names and ensures that they
> stay as one item. Doing this uncovered a few missing dependencies
> and a missing file in some .isolate-files for the component build
> on Mac.
>
> 1st try: https://codereview.chromium.org/970203003/
> 1st revert: https://codereview.chromium.org/985753002/
> 2nd try: https://codereview.chromium.org/1103793002/
> 2nd revert: https://codereview.chromium.org/1129493003/
> 3rd try: https://codereview.chromium.org/1130523003/
> 3rd revert: https://codereview.chromium.org/1131363003/
> BUG=462248
>
> Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
> Cr-Commit-Position: refs/heads/master@{#338402}
TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462248
Committed: https://crrev.com/7b908c0aedf17bed5a8099a47d872b58b7badfde
Cr-Commit-Position: refs/heads/master@{#338497}
Patch Set 1 #
Created: 5 years, 5 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|