Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1227843004: Revert of Add support for escaped target names in isolate driver (4th try) (Closed)

Created:
5 years, 5 months ago by Noel Gordon
Modified:
5 years, 5 months ago
Reviewers:
nyquist, Vadim Sh., Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for escaped target names in isolate driver (4th try) (patchset #2 id:20001 of https://codereview.chromium.org/1221333013/) Reason for revert: Speculative revert: appreas to have broken the GPU mac builders. http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141 Original issue's description: > Add support for escaped target names in isolate driver (4th try) > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. Doing this uncovered a few missing dependencies > and a missing file in some .isolate-files for the component build > on Mac. > > 1st try: https://codereview.chromium.org/970203003/ > 1st revert: https://codereview.chromium.org/985753002/ > 2nd try: https://codereview.chromium.org/1103793002/ > 2nd revert: https://codereview.chromium.org/1129493003/ > 3rd try: https://codereview.chromium.org/1130523003/ > 3rd revert: https://codereview.chromium.org/1131363003/ > BUG=462248 > > Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f > Cr-Commit-Position: refs/heads/master@{#338402} TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Committed: https://crrev.com/7b908c0aedf17bed5a8099a47d872b58b7badfde Cr-Commit-Position: refs/heads/master@{#338497}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M chrome/chrome.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/isolate_driver.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Noel Gordon
Created Revert of Add support for escaped target names in isolate driver (4th try)
5 years, 5 months ago (2015-07-13 11:29:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227843004/1
5 years, 5 months ago (2015-07-13 11:29:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 11:30:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b908c0aedf17bed5a8099a47d872b58b7badfde Cr-Commit-Position: refs/heads/master@{#338497}
5 years, 5 months ago (2015-07-13 11:31:07 UTC) #4
Noel Gordon
5 years, 5 months ago (2015-07-13 14:25:25 UTC) #5
Message was sent while issue was closed.
Yeap, GPU build went green after this revert.

Powered by Google App Engine
This is Rietveld 408576698