content/renderer/render_frame_impl.h - Issue 1227823010: Handle empty error pages in DidFinishDocumentLoad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1227823010: Handle empty error pages in DidFinishDocumentLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable test on android, like the other error page tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index b0106b7d17170fd74f794632f0b68ab66ca1a313..7d285f3a04f369fc73478d79282e2826a9b5ef27 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -431,7 +431,8 @@ class CONTENT_EXPORT RenderFrameImpl

blink::WebTextDirection direction);

virtual void didChangeIcon(blink::WebLocalFrame* frame,

blink::WebIconURL::Type icon_type);

- virtual void didFinishDocumentLoad(blink::WebLocalFrame* frame);

+ virtual void didFinishDocumentLoad(blink::WebLocalFrame* frame,

+ bool document_is_empty);

virtual void didHandleOnloadEvents(blink::WebLocalFrame* frame);

virtual void didFailLoad(blink::WebLocalFrame* frame,

const blink::WebURLError& error,

@@ -467,8 +468,6 @@ class CONTENT_EXPORT RenderFrameImpl

virtual void didReceiveResponse(blink::WebLocalFrame* frame,

unsigned identifier,

const blink::WebURLResponse& response);

- virtual void didFinishResourceLoad(blink::WebLocalFrame* frame,

- unsigned identifier);

virtual void didLoadResourceFromMemoryCache(

blink::WebLocalFrame* frame,

const blink::WebURLRequest& request,