Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 1227823010: Handle empty error pages in DidFinishDocumentLoad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable test on android, like the other error page tests Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/internal_document_state_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_frame_test_proxy.h
diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h
index 8f0336167d8455c376e83d4c6bc6d851979b8367..87246b6e07da9927f63fd6f54da6edacda059809 100644
--- a/components/test_runner/web_frame_test_proxy.h
+++ b/components/test_runner/web_frame_test_proxy.h
@@ -110,9 +110,9 @@ class WebFrameTestProxy : public Base {
Base::didChangeIcon(frame, icon_type);
}
- virtual void didFinishDocumentLoad(blink::WebLocalFrame* frame) {
+ virtual void didFinishDocumentLoad(blink::WebLocalFrame* frame, bool empty) {
base_proxy_->DidFinishDocumentLoad(frame);
- Base::didFinishDocumentLoad(frame);
+ Base::didFinishDocumentLoad(frame, empty);
}
virtual void didHandleOnloadEvents(blink::WebLocalFrame* frame) {
@@ -240,7 +240,6 @@ class WebFrameTestProxy : public Base {
virtual void didFinishResourceLoad(blink::WebLocalFrame* frame,
unsigned identifier) {
base_proxy_->DidFinishResourceLoad(frame, identifier);
- Base::didFinishResourceLoad(frame, identifier);
}
virtual blink::WebNavigationPolicy decidePolicyForNavigation(
« no previous file with comments | « no previous file | content/renderer/internal_document_state_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698