Handle empty error pages in DidFinishDocumentLoad

content/renderer/render_view_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/location.h"
 #include "base/memory/shared_memory.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 1953 matching lines @@
     }
   }
 
   EXPECT_TRUE(is_input_type_called);
   EXPECT_TRUE(is_selection_called);
 
   // InputTypeChange shold be called earlier than SelectionChanged.
   EXPECT_LT(last_input_type, last_selection);
 }
 
-class SuppressErrorPageTest : public RenderViewImplTest {
+class RendererErrorPageTest : public RenderViewImplTest {
  public:
   ContentRendererClient* CreateContentRendererClient() override {
     return new TestContentRendererClient;
   }
 
   RenderViewImpl* view() {
     return static_cast<RenderViewImpl*>(view_);
   }
 
   RenderFrameImpl* frame() {
@@ skipping 10 matching lines @@
 
     void GetNavigationErrorStrings(content::RenderView* render_view,
                                    blink::WebFrame* frame,
                                    const blink::WebURLRequest& failed_request,
                                    const blink::WebURLError& error,
                                    std::string* error_html,
                                    base::string16* error_description) override {
       if (error_html)
         *error_html = "A suffusion of yellow.";
     }
+
+    bool HasErrorPage(int http_status_code,
+                      std::string* error_domain) override {
+      return true;
+    }
   };
 };
 
 #if defined(OS_ANDROID)
 // Crashing on Android: http://crbug.com/311341
 #define MAYBE_Suppresses DISABLED_Suppresses
 #else
 #define MAYBE_Suppresses Suppresses
 #endif
 
-TEST_F(SuppressErrorPageTest, MAYBE_Suppresses) {
+TEST_F(RendererErrorPageTest, MAYBE_Suppresses) {
   WebURLError error;
   error.domain = WebString::fromUTF8(net::kErrorDomain);
   error.reason = net::ERR_FILE_NOT_FOUND;
   error.unreachableURL = GURL("http://example.com/suppress");
   WebLocalFrame* web_frame = GetMainFrame();
 
   // Start a load that will reach provisional state synchronously,
   // but won't complete synchronously.
   CommonNavigationParams common_params;
   common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
@@ skipping 10 matching lines @@
             base::UTF16ToASCII(web_frame->contentAsText(kMaxOutputCharacters)));
 }
 
 #if defined(OS_ANDROID)
 // Crashing on Android: http://crbug.com/311341
 #define MAYBE_DoesNotSuppress DISABLED_DoesNotSuppress
 #else
 #define MAYBE_DoesNotSuppress DoesNotSuppress
 #endif
 
-TEST_F(SuppressErrorPageTest, MAYBE_DoesNotSuppress) {
+TEST_F(RendererErrorPageTest, MAYBE_DoesNotSuppress) {
   WebURLError error;
   error.domain = WebString::fromUTF8(net::kErrorDomain);
   error.reason = net::ERR_FILE_NOT_FOUND;
   error.unreachableURL = GURL("http://example.com/dont-suppress");
   WebLocalFrame* web_frame = GetMainFrame();
 
   // Start a load that will reach provisional state synchronously,
   // but won't complete synchronously.
   CommonNavigationParams common_params;
   common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
   common_params.url = GURL("data:text/html,test data");
   TestRenderFrame* main_frame = static_cast<TestRenderFrame*>(frame());
   main_frame->Navigate(common_params, StartNavigationParams(),
                        RequestNavigationParams());
 
   // An error occurred.
   main_frame->didFailProvisionalLoad(web_frame, error,
                                      blink::WebStandardCommit);
 
   // The error page itself is loaded asynchronously.
   FrameLoadWaiter(main_frame).Wait();
   const int kMaxOutputCharacters = 22;
   EXPECT_EQ("A suffusion of yellow.",
             base::UTF16ToASCII(web_frame->contentAsText(kMaxOutputCharacters)));
 }
 
+TEST_F(RendererErrorPageTest, HttpStatusCodeErrorWithEmptyBody) {
+  blink::WebURLResponse response;
+  response.initialize();
+  response.setHTTPStatusCode(503);
+  WebLocalFrame* web_frame = GetMainFrame();
+
+  // Start a load that will reach provisional state synchronously,
+  // but won't complete synchronously.
+  CommonNavigationParams common_params;
+  common_params.navigation_type = FrameMsg_Navigate_Type::NORMAL;
+  common_params.url = GURL("data:text/html,test data");
+  TestRenderFrame* main_frame = static_cast<TestRenderFrame*>(frame());
+  main_frame->Navigate(common_params, StartNavigationParams(),
+                       RequestNavigationParams());
+
+  // Emulate a 4xx/5xx main resource response with an empty body.
+  main_frame->didReceiveResponse(web_frame, 1, response);
+  main_frame->didFinishDocumentLoad(web_frame, true);

[Charlie Reis, 2015/07/13 20:42:43]

Sanity check: This won't get flaky if the actual data URL later finishes, right?

[Nate Chapin, 2015/07/13 21:15:26]

It shouldn't. didFinishDocumentLoad() should synchronously start the navigation
to the error page, which should cancel the data url navigation.

+
+  // The error page itself is loaded asynchronously.
+  FrameLoadWaiter(main_frame).Wait();
+  const int kMaxOutputCharacters = 22;
+  EXPECT_EQ("A suffusion of yellow.",
+            base::UTF16ToASCII(web_frame->contentAsText(kMaxOutputCharacters)));
+}
+
 // Ensure the render view sends favicon url update events correctly.
 TEST_F(RenderViewImplTest, SendFaviconURLUpdateEvent) {
   // An event should be sent when a favicon url exists.
   LoadHTML("<html>"
            "<head>"
            "<link rel='icon' href='http://www.google.com/favicon.ico'>"
            "</head>"
            "</html>");
   EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
       ViewHostMsg_UpdateFaviconURL::ID));
@@ skipping 239 matching lines @@
       FROM_HERE,
       base::Bind(&DevToolsAgentTest::CloseWhilePaused, base::Unretained(this)));
   ExecuteJavaScript("debugger;");
 
   // CloseWhilePaused should resume execution and continue here.
   EXPECT_FALSE(IsPaused());
   Detach();
 }
 
 }  // namespace content